[PATCH weston 0/3]Rework libweston versioning take 3
ppaalanen at gmail.com
Tue Aug 2 11:00:16 UTC 2016
On Fri, 22 Jul 2016 14:51:49 +0100
Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Hi all,
> Here is hopefully the final take on the series of the topic in question.
> The changes:
> - Reworked the README, elaborating on why and how to use
> REQUIRE_LIBWESTON_API_VERSION (what to write in your configure), how to
> avoid forward compat and misc working improvements.
> - There is a comment about the strange use of LT_VERSION_INFO
> (Quentin) and we no longer have link errors (there was a typo on my end)
> - Dropped "libweston: do not add libweston-$version to the Cflags" in
> favour of "libweston: remove pkgincludedir variable from libweston.pc"
> - Dropped "libweston: do not use weston version in libweston.pc".
> Around the time of release we could unify the version numbers (i.e.
> reuse the weston ones in libweston).
> I believe I've covered everything, but if something is a bit off please
> let me know.
all three patches are R-b me. Everything passes distcheck.
For patch 1, I agree with Quentin's comment, but that can be done as
I think the text in the "API/ABI (in)stability and parallel
installability" is a bit outdated on the terminology, as we now use
major as the ABI version, while it talks about minor.
Patch 2 raised quite some discussion in IRC again about libtool and
-version-info vs. -version-number vs. let's get away from libtool
completely. Expect a follow-up from Daniel you can fight out with
I will post a follow-up to fix libweston.pc.in renames, as Quentin
I tested with series, plus my libweston.pc.in fix and "automake: list
static libraries before the shared ones" with the following libweston
versions: 0.0.0, 1.11.90, 1.12.0, 2.0.0, 2.0.7, 2.1.0, 2.1.3
They all install what I expect. There is *no* libweston.so installed,
so that is good now.
I notice that libweston.pc says the version is the weston version, not
the libweston version, but I think that's fine, isn't it? I means that
pre-releases of libweston-2 will have version 1.12.9x instead of
jumping straight to 2.0.0.
Before the very next release of 1.11.91, we still need to set the
libweston versions up, and we need to update releasing.txt with the
proper guidelines on changing and checking the versions so that Bryce
will know how it should work.
Pushed all three:
78a3637..6735145 master -> master
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 811 bytes
Desc: OpenPGP digital signature
More information about the wayland-devel