[PATCH libinput] gestures: reduce the 2fg scroll timeout to 150ms

Peter Hutterer peter.hutterer at who-t.net
Thu Aug 4 05:07:45 UTC 2016


On Wed, Aug 03, 2016 at 01:06:01PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 03-08-16 11:36, Peter Hutterer wrote:
> > This timeout is there to switch to scrolling when the fingers rest on the
> > touchpad unmoving and thus avoids the initial scroll threshold for slow
> > scrolls.
> > 
> > Since the only other gestures we support are swipe (usually a fast movement)
> > and pinch-and-rotate (also a fast movement) we can drop the timeout down
> > significantly and thus make the scroll feel more reactive.
> > 
> > https://bugs.freedesktop.org/show_bug.cgi?id=93504
> > 
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
> Sounds like a good idea to me, but as Martin already pointed out
> the commit subject and the actual change do not match up.

whoops. this should've been 150ms everywhere. I'll change this locally,
testing confirms 150ms still works as expected.

Cheers,
   Peter
 
> > ---
> >  src/evdev-mt-touchpad-gestures.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-touchpad-gestures.c
> > index acfc875..c965e11 100644
> > --- a/src/evdev-mt-touchpad-gestures.c
> > +++ b/src/evdev-mt-touchpad-gestures.c
> > @@ -30,7 +30,7 @@
> >  #include "evdev-mt-touchpad.h"
> > 
> >  #define DEFAULT_GESTURE_SWITCH_TIMEOUT ms2us(100)
> > -#define DEFAULT_GESTURE_2FG_SCROLL_TIMEOUT ms2us(500)
> > +#define DEFAULT_GESTURE_2FG_SCROLL_TIMEOUT ms2us(200)
> > 
> >  static inline const char*
> >  gesture_state_to_str(enum tp_gesture_state state)
> > 


More information about the wayland-devel mailing list