[PATCH weston v3 4/6] Add a resource creation signal

Giulio Camuffo giuliocamuffo at gmail.com
Thu Aug 11 13:30:37 UTC 2016


2016-08-11 14:34 GMT+02:00 Pekka Paalanen <ppaalanen at gmail.com>:
> Hi Giulio,
> what is in this patch looks good, but I think there could be more.
> There is no test that would excercise
> wl_client_add_resource_created_signal().

Right, i'll add it.

> wl_client destruction assumes that all resource listeners are removed
> before freeing wl_client, but the documentation does not say that one
> MUST listen for wl_client destruction and at that point the latest
> remove all resource listeners.
> Or, do the trick with wl_lists: remove the list head, so it is possible
> to remove the members also afterwards. I didn't check it that's nice
> with wl_signal, though.

A signal is just a wl_list, so i don't see why it shouldn't work. I'll do that.

> This is also possible to fix in a simple follow-up though, so I'll see
> if I just land this and ask for that. I already deemded patches 1-3
> ready to land.

Well, i can do a new version, it's no problem.


> Thanks,
> pq

More information about the wayland-devel mailing list