[PATCH weston 6/6] libweston-desktop: Implement xdg_shell_v6

Quentin Glidic sardemff7+wayland at sardemff7.net
Fri Aug 12 08:41:37 UTC 2016


From: Quentin Glidic <sardemff7+git at sardemff7.net>

Signed-off-by: Quentin Glidic <sardemff7+git at sardemff7.net>
Acked-by: Jonas Ådahl <jadahl at gmail.com>
Acked-by: Giulio Camuffo <giulio.camuffo at kdab.com>

Differential Revision: https://phabricator.freedesktop.org/D1210
---
 Makefile.am                           |    4 +
 libweston-desktop/libweston-desktop.c |   10 +
 libweston-desktop/xdg-shell-v6.c      | 1230 +++++++++++++++++++++++++++++++++
 libweston/compositor.c                |    6 +
 libweston/compositor.h                |    2 +
 5 files changed, 1252 insertions(+)
 create mode 100644 libweston-desktop/xdg-shell-v6.c

diff --git a/Makefile.am b/Makefile.am
index 85fd718..47fc643 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -119,13 +119,17 @@ libweston_desktop_ at LIBWESTON_MAJOR@_la_SOURCES =	\
 	libweston-desktop/seat.c			\
 	libweston-desktop/surface.c			\
 	libweston-desktop/wl-shell.c			\
+	libweston-desktop/xdg-shell-v6.c		\
 	libweston-desktop/xdg-shell-v5.c		\
 	libweston-desktop/xwayland.c
 
 nodist_libweston_desktop_ at LIBWESTON_MAJOR@_la_SOURCES =		\
+	protocol/xdg-shell-unstable-v6-protocol.c		\
+	protocol/xdg-shell-unstable-v6-server-protocol.h	\
 	protocol/xdg-shell-unstable-v5-protocol.c		\
 	protocol/xdg-shell-unstable-v5-server-protocol.h
 
+libweston-desktop- at LIBWESTON_MAJOR@.la libweston-desktop/libweston_desktop_ at LIBWESTON_MAJOR@_la-xdg-shell-v6.lo: protocol/xdg-shell-unstable-v6-server-protocol.h
 libweston-desktop- at LIBWESTON_MAJOR@.la libweston-desktop/libweston_desktop_ at LIBWESTON_MAJOR@_la-xdg-shell-v5.lo: protocol/xdg-shell-unstable-v5-server-protocol.h
 
 if SYSTEMD_NOTIFY_SUPPORT
diff --git a/libweston-desktop/libweston-desktop.c b/libweston-desktop/libweston-desktop.c
index 4583ede..0ee1139 100644
--- a/libweston-desktop/libweston-desktop.c
+++ b/libweston-desktop/libweston-desktop.c
@@ -40,6 +40,7 @@ struct weston_desktop {
 	struct weston_compositor *compositor;
 	struct weston_desktop_api api;
 	void *user_data;
+	struct wl_global *xdg_shell_v6;
 	struct wl_global *xdg_shell_v5;
 	struct wl_global *wl_shell;
 };
@@ -69,6 +70,13 @@ weston_desktop_create(struct weston_compositor *compositor,
 		MIN(sizeof(struct weston_desktop_api), api->struct_size);
 	memcpy(&desktop->api, api, desktop->api.struct_size);
 
+	desktop->xdg_shell_v6 =
+		weston_desktop_xdg_shell_v6_create(desktop, display);
+	if (desktop->xdg_shell_v6 == NULL) {
+		weston_desktop_destroy(desktop);
+		return NULL;
+	}
+
 	desktop->xdg_shell_v5 =
 		weston_desktop_xdg_shell_v5_create(desktop, display);
 	if (desktop->xdg_shell_v5 == NULL) {
@@ -98,6 +106,8 @@ weston_desktop_destroy(struct weston_desktop *desktop)
 		wl_global_destroy(desktop->wl_shell);
 	if (desktop->xdg_shell_v5 != NULL)
 		wl_global_destroy(desktop->xdg_shell_v5);
+	if (desktop->xdg_shell_v6 != NULL)
+		wl_global_destroy(desktop->xdg_shell_v6);
 
 	free(desktop);
 }
diff --git a/libweston-desktop/xdg-shell-v6.c b/libweston-desktop/xdg-shell-v6.c
new file mode 100644
index 0000000..2f9c9ae
--- /dev/null
+++ b/libweston-desktop/xdg-shell-v6.c
@@ -0,0 +1,1230 @@
+/*
+ * Copyright © 2010-2012 Intel Corporation
+ * Copyright © 2011-2012 Collabora, Ltd.
+ * Copyright © 2013 Raspberry Pi Foundation
+ * Copyright © 2016 Quentin "Sardem FF7" Glidic
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#include "config.h"
+
+#include <stdbool.h>
+#include <assert.h>
+
+#include <wayland-server.h>
+
+#include "compositor.h"
+#include "zalloc.h"
+#include "protocol/xdg-shell-unstable-v6-server-protocol.h"
+
+#include "libweston-desktop.h"
+#include "internal.h"
+
+#define WD_XDG_SHELL_PROTOCOL_VERSION 1
+
+static const char *weston_desktop_xdg_toplevel_role = "xdg_toplevel";
+static const char *weston_desktop_xdg_popup_role = "xdg_popup";
+
+struct weston_desktop_xdg_positioner {
+	struct weston_desktop *desktop;
+	struct weston_desktop_client *client;
+	struct wl_resource *resource;
+
+	struct weston_size size;
+	struct weston_geometry anchor_rect;
+	enum zxdg_positioner_v6_anchor anchor;
+	enum zxdg_positioner_v6_gravity gravity;
+	enum zxdg_positioner_v6_constrain_adjustment constrain_adjustment;
+	struct weston_position offset;
+};
+
+enum weston_desktop_xdg_surface_role {
+ 	WESTON_DESKTOP_XDG_SURFACE_ROLE_NONE,
+ 	WESTON_DESKTOP_XDG_SURFACE_ROLE_TOPLEVEL,
+ 	WESTON_DESKTOP_XDG_SURFACE_ROLE_POPUP,
+};
+
+struct weston_desktop_xdg_surface {
+	struct wl_resource *resource;
+	struct weston_desktop *desktop;
+	struct weston_surface *surface;
+	struct weston_desktop_surface *desktop_surface;
+	bool configured;
+	struct wl_event_source *configure_idle;
+	uint32_t configure_serial;
+
+	bool has_next_geometry;
+	struct weston_geometry next_geometry;
+
+	enum weston_desktop_xdg_surface_role role;
+};
+
+struct weston_desktop_xdg_toplevel {
+	struct weston_desktop_xdg_surface base;
+
+	struct wl_resource *resource;
+	bool added;
+	struct weston_size requested_size;
+	struct {
+		bool maximized;
+		bool fullscreen;
+		bool resizing;
+		bool activated;
+	} requested_state, next_state, state;
+	struct weston_size
+		next_max_size, max_size,
+		next_min_size, min_size;
+};
+
+struct weston_desktop_xdg_popup {
+	struct weston_desktop_xdg_surface base;
+
+	struct wl_resource *resource;
+	bool committed;
+	struct weston_desktop_xdg_surface *parent;
+	struct weston_desktop_seat *seat;
+	struct weston_geometry geometry;
+};
+
+#define weston_desktop_surface_role_biggest_size (sizeof(struct weston_desktop_xdg_toplevel))
+
+
+static struct weston_geometry
+weston_desktop_xdg_positioner_get_geometry(struct weston_desktop_xdg_positioner *positioner,
+					   struct weston_desktop_surface *dsurface,
+					   struct weston_desktop_surface *parent)
+{
+	struct weston_geometry geometry = {
+		.x = positioner->offset.x,
+		.y = positioner->offset.y,
+		.width = positioner->size.width,
+		.height = positioner->size.height,
+	};
+
+	if (positioner->anchor & ZXDG_POSITIONER_V6_ANCHOR_TOP)
+		geometry.y += positioner->anchor_rect.y;
+	else if (positioner->anchor & ZXDG_POSITIONER_V6_ANCHOR_BOTTOM)
+		geometry.y += positioner->anchor_rect.y + positioner->anchor_rect.height;
+	else
+		geometry.y += positioner->anchor_rect.y + positioner->anchor_rect.height / 2;
+
+	if (positioner->anchor & ZXDG_POSITIONER_V6_ANCHOR_LEFT)
+		geometry.x += positioner->anchor_rect.x;
+	else if (positioner->anchor & ZXDG_POSITIONER_V6_ANCHOR_RIGHT)
+		geometry.x += positioner->anchor_rect.x + positioner->anchor_rect.width;
+	else
+		geometry.x += positioner->anchor_rect.x + positioner->anchor_rect.width / 2;
+
+	if (positioner->gravity & ZXDG_POSITIONER_V6_GRAVITY_TOP)
+		geometry.y -= geometry.height;
+	else if (positioner->gravity & ZXDG_POSITIONER_V6_GRAVITY_BOTTOM)
+		geometry.y = geometry.y;
+	else
+		geometry.y -= geometry.height / 2;
+
+	if (positioner->gravity & ZXDG_POSITIONER_V6_GRAVITY_LEFT)
+		geometry.x -= geometry.width;
+	else if (positioner->gravity & ZXDG_POSITIONER_V6_GRAVITY_RIGHT)
+		geometry.x = geometry.x;
+	else
+		geometry.x -= geometry.width / 2;
+
+	if (positioner->constrain_adjustment == ZXDG_POSITIONER_V6_CONSTRAIN_ADJUSTMENT_NONE)
+		return geometry;
+
+	/* TODO: add compositor policy configuration and the code here */
+
+	return geometry;
+}
+
+static void
+weston_desktop_xdg_positioner_protocol_set_size(struct wl_client *wl_client,
+						struct wl_resource *resource,
+						int32_t width, int32_t height)
+{
+	struct weston_desktop_xdg_positioner *positioner =
+		wl_resource_get_user_data(resource);
+
+	if (width < 1 || height < 1) {
+		wl_resource_post_error(resource,
+				       ZXDG_POSITIONER_V6_ERROR_INVALID_INPUT,
+				       "width and height must be positives and non-zero");
+		return;
+	}
+
+	positioner->size.width = width;
+	positioner->size.height = height;
+}
+
+static void
+weston_desktop_xdg_positioner_protocol_set_anchor_rect(struct wl_client *wl_client,
+						       struct wl_resource *resource,
+						       int32_t x, int32_t y,
+						       int32_t width, int32_t height)
+{
+	struct weston_desktop_xdg_positioner *positioner =
+		wl_resource_get_user_data(resource);
+
+	if (width < 1 || height < 1) {
+		wl_resource_post_error(resource,
+				       ZXDG_POSITIONER_V6_ERROR_INVALID_INPUT,
+				       "width and height must be positives and non-zero");
+		return;
+	}
+
+	positioner->anchor_rect.x = x;
+	positioner->anchor_rect.y = y;
+	positioner->anchor_rect.width = width;
+	positioner->anchor_rect.height = height;
+}
+
+static void
+weston_desktop_xdg_positioner_protocol_set_anchor(struct wl_client *wl_client,
+						  struct wl_resource *resource,
+						  enum zxdg_positioner_v6_anchor anchor)
+{
+	struct weston_desktop_xdg_positioner *positioner =
+		wl_resource_get_user_data(resource);
+
+	if (((anchor & ZXDG_POSITIONER_V6_ANCHOR_TOP ) &&
+	      (anchor & ZXDG_POSITIONER_V6_ANCHOR_BOTTOM)) ||
+	    ((anchor & ZXDG_POSITIONER_V6_ANCHOR_LEFT) &&
+	       (anchor & ZXDG_POSITIONER_V6_ANCHOR_RIGHT))) {
+		wl_resource_post_error(resource,
+				       ZXDG_POSITIONER_V6_ERROR_INVALID_INPUT,
+				       "same-axis values are not allowed");
+		return;
+	}
+
+	positioner->anchor = anchor;
+}
+
+static void
+weston_desktop_xdg_positioner_protocol_set_gravity(struct wl_client *wl_client,
+						   struct wl_resource *resource,
+						   enum zxdg_positioner_v6_gravity gravity)
+{
+	struct weston_desktop_xdg_positioner *positioner =
+		wl_resource_get_user_data(resource);
+
+	if (((gravity & ZXDG_POSITIONER_V6_GRAVITY_TOP) &&
+	     (gravity & ZXDG_POSITIONER_V6_GRAVITY_BOTTOM)) ||
+	    ((gravity & ZXDG_POSITIONER_V6_GRAVITY_LEFT) &&
+	     (gravity & ZXDG_POSITIONER_V6_GRAVITY_RIGHT))) {
+		wl_resource_post_error(resource,
+				       ZXDG_POSITIONER_V6_ERROR_INVALID_INPUT,
+				       "same-axis values are not allowed");
+		return;
+	}
+
+	positioner->gravity = gravity;
+}
+
+static void
+weston_desktop_xdg_positioner_protocol_set_constrain_adjustment(struct wl_client *wl_client,
+								struct wl_resource *resource,
+								enum zxdg_positioner_v6_constrain_adjustment constrain_adjustment)
+{
+	struct weston_desktop_xdg_positioner *positioner =
+		wl_resource_get_user_data(resource);
+
+	positioner->constrain_adjustment = constrain_adjustment;
+}
+
+static void
+weston_desktop_xdg_positioner_protocol_set_offset(struct wl_client *wl_client,
+						  struct wl_resource *resource,
+						  int32_t x, int32_t y)
+{
+	struct weston_desktop_xdg_positioner *positioner =
+		wl_resource_get_user_data(resource);
+
+	positioner->offset.x = x;
+	positioner->offset.y = y;
+}
+
+static void
+weston_desktop_xdg_positioner_destroy(struct wl_resource *resource)
+{
+	struct weston_desktop_xdg_positioner *positioner =
+		wl_resource_get_user_data(resource);
+
+	free(positioner);
+}
+
+static const struct zxdg_positioner_v6_interface weston_desktop_xdg_positioner_implementation = {
+	.destroy                  = weston_desktop_destroy_request,
+	.set_size                 = weston_desktop_xdg_positioner_protocol_set_size,
+	.set_anchor_rect          = weston_desktop_xdg_positioner_protocol_set_anchor_rect,
+	.set_anchor               = weston_desktop_xdg_positioner_protocol_set_anchor,
+	.set_gravity              = weston_desktop_xdg_positioner_protocol_set_gravity,
+	.set_constrain_adjustment = weston_desktop_xdg_positioner_protocol_set_constrain_adjustment,
+	.set_offset               = weston_desktop_xdg_positioner_protocol_set_offset,
+};
+
+static void
+weston_desktop_xdg_surface_schedule_configure(struct weston_desktop_xdg_surface *surface);
+
+static void
+weston_desktop_xdg_toplevel_protocol_set_parent(struct wl_client *wl_client,
+						struct wl_resource *resource,
+						struct wl_resource *parent_resource)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_desktop_xdg_toplevel *toplevel =
+		weston_desktop_surface_get_implementation_data(dsurface);
+	struct weston_desktop_surface *parent = NULL;
+
+	if (parent_resource != NULL)
+		parent = wl_resource_get_user_data(parent_resource);
+	weston_desktop_api_set_parent(toplevel->base.desktop, dsurface, parent);
+}
+
+static void
+weston_desktop_xdg_toplevel_protocol_set_title(struct wl_client *wl_client,
+					       struct wl_resource *resource,
+					       const char *title)
+{
+	struct weston_desktop_surface *toplevel =
+		wl_resource_get_user_data(resource);
+
+	weston_desktop_surface_set_title(toplevel, title);
+}
+
+static void
+weston_desktop_xdg_toplevel_protocol_set_app_id(struct wl_client *wl_client,
+						struct wl_resource *resource,
+						const char *app_id)
+{
+	struct weston_desktop_surface *toplevel =
+		wl_resource_get_user_data(resource);
+
+	weston_desktop_surface_set_app_id(toplevel, app_id);
+}
+
+static void
+weston_desktop_xdg_toplevel_protocol_show_window_menu(struct wl_client *wl_client,
+						      struct wl_resource *resource,
+						      struct wl_resource *seat_resource,
+						      uint32_t serial,
+						      int32_t x, int32_t y)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_seat *seat =
+		wl_resource_get_user_data(seat_resource);
+	struct weston_desktop_xdg_toplevel *toplevel =
+		weston_desktop_surface_get_implementation_data(dsurface);
+
+	weston_desktop_api_show_window_menu(toplevel->base.desktop,
+					    dsurface, seat, x, y);
+}
+
+static void
+weston_desktop_xdg_toplevel_protocol_move(struct wl_client *wl_client,
+					  struct wl_resource *resource,
+					  struct wl_resource *seat_resource,
+					  uint32_t serial)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_seat *seat =
+		wl_resource_get_user_data(seat_resource);
+	struct weston_desktop_xdg_toplevel *toplevel =
+		weston_desktop_surface_get_implementation_data(dsurface);
+
+	weston_desktop_api_move(toplevel->base.desktop, dsurface, seat, serial);
+}
+
+static void
+weston_desktop_xdg_toplevel_protocol_resize(struct wl_client *wl_client,
+					    struct wl_resource *resource,
+					    struct wl_resource *seat_resource,
+					    uint32_t serial,
+					    enum zxdg_toplevel_v6_resize_edge edges)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_seat *seat =
+		wl_resource_get_user_data(seat_resource);
+	struct weston_desktop_xdg_toplevel *toplevel =
+		weston_desktop_surface_get_implementation_data(dsurface);
+
+	weston_desktop_api_resize(toplevel->base.desktop,
+				  dsurface, seat, serial, edges);
+}
+
+static void
+weston_desktop_xdg_toplevel_ack_configure(struct weston_desktop_xdg_toplevel *toplevel)
+{
+	toplevel->next_state = toplevel->requested_state;
+}
+
+static void
+weston_desktop_xdg_toplevel_protocol_set_min_size(struct wl_client *wl_client,
+						  struct wl_resource *resource,
+						  int32_t width, int32_t height)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_desktop_xdg_toplevel *toplevel =
+		weston_desktop_surface_get_implementation_data(dsurface);
+
+	toplevel->next_min_size.width = width;
+	toplevel->next_min_size.height = height;
+}
+
+static void
+weston_desktop_xdg_toplevel_protocol_set_max_size(struct wl_client *wl_client,
+						  struct wl_resource *resource,
+						  int32_t width, int32_t height)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_desktop_xdg_toplevel *toplevel =
+		weston_desktop_surface_get_implementation_data(dsurface);
+
+	toplevel->next_max_size.width = width;
+	toplevel->next_max_size.height = height;
+}
+
+static void
+weston_desktop_xdg_toplevel_protocol_set_maximized(struct wl_client *wl_client,
+						   struct wl_resource *resource)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_desktop_xdg_toplevel *toplevel =
+		weston_desktop_surface_get_implementation_data(dsurface);
+
+	weston_desktop_api_maximized_requested(toplevel->base.desktop, dsurface, true);
+}
+
+static void
+weston_desktop_xdg_toplevel_protocol_unset_maximized(struct wl_client *wl_client,
+						     struct wl_resource *resource)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_desktop_xdg_toplevel *toplevel =
+		weston_desktop_surface_get_implementation_data(dsurface);
+
+	weston_desktop_api_maximized_requested(toplevel->base.desktop, dsurface, false);
+}
+
+static void
+weston_desktop_xdg_toplevel_protocol_set_fullscreen(struct wl_client *wl_client,
+						    struct wl_resource *resource,
+						    struct wl_resource *output_resource)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_desktop_xdg_toplevel *toplevel =
+		weston_desktop_surface_get_implementation_data(dsurface);
+	struct weston_output *output = NULL;
+
+	if (output_resource != NULL)
+		output = wl_resource_get_user_data(output_resource);
+
+	weston_desktop_api_fullscreen_requested(toplevel->base.desktop, dsurface,
+						true, output);
+}
+
+static void
+weston_desktop_xdg_toplevel_protocol_unset_fullscreen(struct wl_client *wl_client,
+						      struct wl_resource *resource)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_desktop_xdg_toplevel *toplevel =
+		weston_desktop_surface_get_implementation_data(dsurface);
+
+	weston_desktop_api_fullscreen_requested(toplevel->base.desktop, dsurface,
+						false, NULL);
+}
+
+static void
+weston_desktop_xdg_toplevel_protocol_set_minimized(struct wl_client *wl_client,
+						   struct wl_resource *resource)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_desktop_xdg_toplevel *toplevel =
+		weston_desktop_surface_get_implementation_data(dsurface);
+
+	weston_desktop_api_minimized_requested(toplevel->base.desktop, dsurface);
+}
+
+static void
+weston_desktop_xdg_toplevel_send_configure(struct weston_desktop_xdg_toplevel *toplevel)
+{
+	uint32_t *s;
+	struct wl_array states;
+
+	wl_array_init(&states);
+	if (toplevel->requested_state.maximized) {
+		s = wl_array_add(&states, sizeof(uint32_t));
+		*s = ZXDG_TOPLEVEL_V6_STATE_MAXIMIZED;
+	}
+	if (toplevel->requested_state.fullscreen) {
+		s = wl_array_add(&states, sizeof(uint32_t));
+		*s = ZXDG_TOPLEVEL_V6_STATE_FULLSCREEN;
+	}
+	if (toplevel->requested_state.resizing) {
+		s = wl_array_add(&states, sizeof(uint32_t));
+		*s = ZXDG_TOPLEVEL_V6_STATE_RESIZING;
+	}
+	if (toplevel->requested_state.activated) {
+		s = wl_array_add(&states, sizeof(uint32_t));
+		*s = ZXDG_TOPLEVEL_V6_STATE_ACTIVATED;
+	}
+
+	zxdg_toplevel_v6_send_configure(toplevel->resource,
+					toplevel->requested_size.width,
+					toplevel->requested_size.height,
+					&states);
+
+	wl_array_release(&states);
+};
+
+static void
+weston_desktop_xdg_toplevel_set_maximized(struct weston_desktop_surface *dsurface,
+					  void *user_data, bool maximized)
+{
+	struct weston_desktop_xdg_toplevel *toplevel = user_data;
+
+	if (toplevel->state.maximized == maximized)
+		return;
+
+	toplevel->requested_state.maximized = maximized;
+	weston_desktop_xdg_surface_schedule_configure(&toplevel->base);
+}
+
+static void
+weston_desktop_xdg_toplevel_set_fullscreen(struct weston_desktop_surface *dsurface,
+					   void *user_data, bool fullscreen)
+{
+	struct weston_desktop_xdg_toplevel *toplevel = user_data;
+
+	if (toplevel->state.fullscreen == fullscreen)
+		return;
+
+	toplevel->requested_state.fullscreen = fullscreen;
+	weston_desktop_xdg_surface_schedule_configure(&toplevel->base);
+}
+
+static void
+weston_desktop_xdg_toplevel_set_resizing(struct weston_desktop_surface *dsurface,
+					 void *user_data, bool resizing)
+{
+	struct weston_desktop_xdg_toplevel *toplevel = user_data;
+
+	if (toplevel->state.resizing == resizing)
+		return;
+
+	toplevel->requested_state.resizing = resizing;
+	weston_desktop_xdg_surface_schedule_configure(&toplevel->base);
+}
+
+static void
+weston_desktop_xdg_toplevel_set_activated(struct weston_desktop_surface *dsurface,
+					  void *user_data, bool activated)
+{
+	struct weston_desktop_xdg_toplevel *toplevel = user_data;
+
+	if (toplevel->state.activated == activated)
+		return;
+
+	toplevel->requested_state.activated = activated;
+	weston_desktop_xdg_surface_schedule_configure(&toplevel->base);
+}
+
+static void
+weston_desktop_xdg_toplevel_set_size(struct weston_desktop_surface *dsurface,
+				     void *user_data,
+				     int32_t width, int32_t height)
+{
+	struct weston_desktop_xdg_toplevel *toplevel = user_data;
+	struct weston_surface *wsurface =
+		weston_desktop_surface_get_surface(toplevel->base.desktop_surface);
+
+	if (wsurface->width == width && wsurface->height == height)
+		return;
+
+	toplevel->requested_size.width = width;
+	toplevel->requested_size.height = height;
+	weston_desktop_xdg_surface_schedule_configure(&toplevel->base);
+}
+
+static void
+weston_desktop_xdg_toplevel_committed(struct weston_desktop_xdg_toplevel *toplevel,
+				      bool new_buffer, int32_t sx, int32_t sy)
+{
+	struct weston_surface *wsurface =
+		weston_desktop_surface_get_surface(toplevel->base.desktop_surface);
+	bool reconfigure = false;
+
+	if (!new_buffer && !toplevel->added) {
+		weston_desktop_api_surface_added(toplevel->base.desktop,
+					         toplevel->base.desktop_surface);
+		weston_desktop_xdg_surface_schedule_configure(&toplevel->base);
+		toplevel->added = true;
+		return;
+	}
+	if (!new_buffer)
+		return;
+
+	if (toplevel->next_state.maximized || toplevel->next_state.fullscreen)
+		reconfigure =
+			( ( toplevel->requested_size.width != wsurface->width ) ||
+			  ( toplevel->requested_size.height != wsurface->height ) );
+
+	if (reconfigure) {
+		weston_desktop_xdg_surface_schedule_configure(&toplevel->base);
+	} else {
+		toplevel->state = toplevel->next_state;
+		toplevel->min_size = toplevel->next_min_size;
+		toplevel->max_size = toplevel->next_max_size;
+
+		weston_desktop_api_committed(toplevel->base.desktop,
+					     toplevel->base.desktop_surface,
+					     sx, sy);
+	}
+}
+
+static void
+weston_desktop_xdg_toplevel_close(struct weston_desktop_xdg_toplevel *toplevel)
+{
+	zxdg_toplevel_v6_send_close(toplevel->resource);
+}
+
+static bool
+weston_desktop_xdg_toplevel_get_maximized(struct weston_desktop_surface *dsurface,
+					  void *user_data)
+{
+	struct weston_desktop_xdg_toplevel *toplevel = user_data;
+
+	return toplevel->state.maximized;
+}
+
+static bool
+weston_desktop_xdg_toplevel_get_fullscreen(struct weston_desktop_surface *dsurface,
+					   void *user_data)
+{
+	struct weston_desktop_xdg_toplevel *toplevel = user_data;
+
+	return toplevel->state.fullscreen;
+}
+
+static bool
+weston_desktop_xdg_toplevel_get_resizing(struct weston_desktop_surface *dsurface,
+					 void *user_data)
+{
+	struct weston_desktop_xdg_toplevel *toplevel = user_data;
+
+	return toplevel->state.resizing;
+}
+
+static bool
+weston_desktop_xdg_toplevel_get_activated(struct weston_desktop_surface *dsurface,
+					  void *user_data)
+{
+	struct weston_desktop_xdg_toplevel *toplevel = user_data;
+
+	return toplevel->state.activated;
+}
+
+static void
+weston_desktop_xdg_toplevel_destroy(struct weston_desktop_xdg_toplevel *toplevel)
+{
+	if (toplevel->added)
+		weston_desktop_api_surface_removed(toplevel->base.desktop,
+						   toplevel->base.desktop_surface);
+}
+
+static void
+weston_desktop_xdg_toplevel_resource_destroy(struct wl_resource *resource)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+
+	if (dsurface != NULL)
+		weston_desktop_surface_resource_destroy(resource);
+}
+
+static const struct zxdg_toplevel_v6_interface weston_desktop_xdg_toplevel_implementation = {
+	.destroy             = weston_desktop_destroy_request,
+	.set_parent          = weston_desktop_xdg_toplevel_protocol_set_parent,
+	.set_title           = weston_desktop_xdg_toplevel_protocol_set_title,
+	.set_app_id          = weston_desktop_xdg_toplevel_protocol_set_app_id,
+	.show_window_menu    = weston_desktop_xdg_toplevel_protocol_show_window_menu,
+	.move                = weston_desktop_xdg_toplevel_protocol_move,
+	.resize              = weston_desktop_xdg_toplevel_protocol_resize,
+	.set_min_size        = weston_desktop_xdg_toplevel_protocol_set_min_size,
+	.set_max_size        = weston_desktop_xdg_toplevel_protocol_set_max_size,
+	.set_maximized       = weston_desktop_xdg_toplevel_protocol_set_maximized,
+	.unset_maximized     = weston_desktop_xdg_toplevel_protocol_unset_maximized,
+	.set_fullscreen      = weston_desktop_xdg_toplevel_protocol_set_fullscreen,
+	.unset_fullscreen    = weston_desktop_xdg_toplevel_protocol_unset_fullscreen,
+	.set_minimized       = weston_desktop_xdg_toplevel_protocol_set_minimized,
+};
+
+static void
+weston_desktop_xdg_popup_protocol_grab(struct wl_client *wl_client,
+				       struct wl_resource *resource,
+				       struct wl_resource *seat_resource,
+				       uint32_t serial)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_desktop_xdg_popup *popup =
+		weston_desktop_surface_get_implementation_data(dsurface);
+	struct weston_seat *wseat = wl_resource_get_user_data(seat_resource);
+	struct weston_desktop_seat *seat = weston_desktop_seat_from_seat(wseat);
+	struct weston_desktop_surface *topmost;
+	bool parent_is_toplevel =
+		popup->parent->role == WESTON_DESKTOP_XDG_SURFACE_ROLE_TOPLEVEL;
+
+	if (popup->committed) {
+		wl_resource_post_error(popup->resource,
+				       ZXDG_POPUP_V6_ERROR_INVALID_GRAB,
+				       "xdg_popup already is mapped");
+		return;
+	}
+
+	topmost = weston_desktop_seat_popup_grab_get_topmost_surface(seat);
+	if ((topmost == NULL && !parent_is_toplevel) ||
+	    (topmost != NULL && topmost != popup->parent->desktop_surface)) {
+		wl_resource_post_error(popup->resource,
+				       ZXDG_SHELL_V6_ERROR_NOT_THE_TOPMOST_POPUP,
+				       "xdg_popup was not created on the topmost popup");
+		return;
+	}
+
+	popup->seat = seat;
+	weston_desktop_surface_popup_grab(popup->base.desktop_surface,
+					  popup->seat, serial);
+}
+
+static void
+weston_desktop_xdg_popup_send_configure(struct weston_desktop_xdg_popup *popup)
+{
+	zxdg_popup_v6_send_configure(popup->resource,
+				     popup->geometry.x,
+				     popup->geometry.y,
+				     popup->geometry.width,
+				     popup->geometry.height);
+}
+
+static void
+weston_desktop_xdg_popup_update_position(struct weston_desktop_surface *dsurface,
+					 void *user_data);
+
+static void
+weston_desktop_xdg_popup_committed(struct weston_desktop_xdg_popup *popup)
+{
+	if (!popup->committed)
+		weston_desktop_xdg_surface_schedule_configure(&popup->base);
+	popup->committed = true;
+	weston_desktop_xdg_popup_update_position(popup->base.desktop_surface,
+						 popup);
+}
+
+static void
+weston_desktop_xdg_popup_update_position(struct weston_desktop_surface *dsurface,
+					 void *user_data)
+{
+}
+
+static void
+weston_desktop_xdg_popup_close(struct weston_desktop_xdg_popup *popup)
+{
+	zxdg_popup_v6_send_popup_done(popup->resource);
+}
+
+static void
+weston_desktop_xdg_popup_destroy(struct weston_desktop_xdg_popup *popup)
+{
+	struct weston_desktop_surface *topmost;
+	struct weston_desktop_client *client =
+		weston_desktop_surface_get_client(popup->base.desktop_surface);
+
+	if (!weston_desktop_surface_get_grab(popup->base.desktop_surface))
+		return;
+
+	topmost = weston_desktop_seat_popup_grab_get_topmost_surface(popup->seat);
+	if (topmost != popup->base.desktop_surface) {
+		struct wl_resource *client_resource =
+			weston_desktop_client_get_resource(client);
+
+		wl_resource_post_error(client_resource,
+				       ZXDG_SHELL_V6_ERROR_NOT_THE_TOPMOST_POPUP,
+				       "xdg_popup was destroyed while it was not the topmost popup.");
+	}
+
+	weston_desktop_surface_popup_ungrab(popup->base.desktop_surface,
+					    popup->seat);
+}
+
+static void
+weston_desktop_xdg_popup_resource_destroy(struct wl_resource *resource)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+
+	if (dsurface != NULL)
+		weston_desktop_surface_resource_destroy(resource);
+}
+
+static const struct zxdg_popup_v6_interface weston_desktop_xdg_popup_implementation = {
+	.destroy             = weston_desktop_destroy_request,
+	.grab                = weston_desktop_xdg_popup_protocol_grab,
+};
+
+static void
+weston_desktop_xdg_surface_send_configure(void *user_data)
+{
+	struct weston_desktop_xdg_surface *surface = user_data;
+
+	surface->configure_idle = NULL;
+	surface->configure_serial =
+		wl_display_next_serial(weston_desktop_get_display(surface->desktop));
+
+	switch (surface->role) {
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_NONE:
+		assert(0 && "not reached");
+		break;
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_TOPLEVEL:
+		weston_desktop_xdg_toplevel_send_configure((struct weston_desktop_xdg_toplevel *) surface);
+		break;
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_POPUP:
+		weston_desktop_xdg_popup_send_configure((struct weston_desktop_xdg_popup *) surface);
+		break;
+	}
+
+	zxdg_surface_v6_send_configure(surface->resource, surface->configure_serial);
+}
+
+static void
+weston_desktop_xdg_surface_schedule_configure(struct weston_desktop_xdg_surface *surface)
+{
+	struct wl_display *display = weston_desktop_get_display(surface->desktop);
+	struct wl_event_loop *loop = wl_display_get_event_loop(display);
+
+	if (surface->configure_idle != NULL)
+		return;
+	surface->configure_idle =
+		wl_event_loop_add_idle(loop,
+				       weston_desktop_xdg_surface_send_configure,
+				       surface);
+}
+
+static void
+weston_desktop_xdg_surface_protocol_get_toplevel(struct wl_client *wl_client,
+						 struct wl_resource *resource,
+						 uint32_t id)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_surface *wsurface =
+		weston_desktop_surface_get_surface(dsurface);
+	struct weston_desktop_xdg_toplevel *toplevel =
+		weston_desktop_surface_get_implementation_data(dsurface);
+
+	if (weston_surface_set_role(wsurface, weston_desktop_xdg_toplevel_role,
+				    resource, ZXDG_SHELL_V6_ERROR_ROLE) < 0)
+		return;
+
+	toplevel->resource =
+		weston_desktop_surface_add_resource(toplevel->base.desktop_surface,
+						    &zxdg_toplevel_v6_interface,
+						    &weston_desktop_xdg_toplevel_implementation,
+						    id, weston_desktop_xdg_toplevel_resource_destroy);
+	if (toplevel->resource == NULL)
+		return;
+
+	toplevel->base.role = WESTON_DESKTOP_XDG_SURFACE_ROLE_TOPLEVEL;
+}
+
+static void
+weston_desktop_xdg_surface_protocol_get_popup(struct wl_client *wl_client,
+					      struct wl_resource *resource,
+					      uint32_t id,
+					      struct wl_resource *parent_resource,
+					      struct wl_resource *positioner_resource)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_surface *wsurface =
+		weston_desktop_surface_get_surface(dsurface);
+	struct weston_desktop_xdg_popup *popup =
+		weston_desktop_surface_get_implementation_data(dsurface);
+	struct weston_desktop_surface *parent_surface =
+		wl_resource_get_user_data(parent_resource);
+	struct weston_desktop_xdg_surface *parent =
+		weston_desktop_surface_get_implementation_data(parent_surface);
+	struct weston_desktop_xdg_positioner *positioner =
+		wl_resource_get_user_data(positioner_resource);
+
+	if (weston_surface_set_role(wsurface, weston_desktop_xdg_popup_role,
+				    resource, ZXDG_SHELL_V6_ERROR_ROLE) < 0)
+		return;
+
+	popup->resource =
+		weston_desktop_surface_add_resource(popup->base.desktop_surface,
+						    &zxdg_popup_v6_interface,
+						    &weston_desktop_xdg_popup_implementation,
+						    id, weston_desktop_xdg_popup_resource_destroy);
+	if (popup->resource == NULL)
+		return;
+
+	popup->base.role = WESTON_DESKTOP_XDG_SURFACE_ROLE_POPUP;
+	popup->parent = parent;
+
+	popup->geometry =
+		weston_desktop_xdg_positioner_get_geometry(positioner,
+							   dsurface,
+							   parent_surface);
+
+	weston_desktop_surface_set_relative_to(popup->base.desktop_surface,
+					       parent_surface,
+					       popup->geometry.x,
+					       popup->geometry.y,
+					       true);
+}
+
+static bool
+weston_desktop_xdg_surface_check_role(struct weston_desktop_xdg_surface *surface)
+{
+	struct weston_surface *wsurface =
+		weston_desktop_surface_get_surface(surface->desktop_surface);
+	const char *role;
+
+	role = weston_surface_get_role(wsurface);
+	if (role != NULL &&
+	    (role == weston_desktop_xdg_toplevel_role ||
+	     role == weston_desktop_xdg_popup_role))
+	     return true;
+
+	wl_resource_post_error(surface->resource,
+			       ZXDG_SURFACE_V6_ERROR_NOT_CONSTRUCTED,
+			       "xdg_surface must have a role");
+	return false;
+}
+
+static void
+weston_desktop_xdg_surface_protocol_set_window_geometry(struct wl_client *wl_client,
+							struct wl_resource *resource,
+							int32_t x, int32_t y,
+							int32_t width, int32_t height)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_desktop_xdg_surface *surface =
+		weston_desktop_surface_get_implementation_data(dsurface);
+
+	if (!weston_desktop_xdg_surface_check_role(surface))
+		return;
+
+	surface->has_next_geometry = true;
+	surface->next_geometry.x = x;
+	surface->next_geometry.y = y;
+	surface->next_geometry.width = width;
+	surface->next_geometry.height = height;
+}
+
+static void
+weston_desktop_xdg_surface_protocol_ack_configure(struct wl_client *wl_client,
+						  struct wl_resource *resource,
+						  uint32_t serial)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+	struct weston_desktop_xdg_surface *surface =
+		weston_desktop_surface_get_implementation_data(dsurface);
+
+	if (!weston_desktop_xdg_surface_check_role(surface))
+		return;
+
+	if (surface->configure_serial != serial)
+		return;
+
+	surface->configured = true;
+
+	switch (surface->role) {
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_NONE:
+		assert(0 && "not reached");
+		break;
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_TOPLEVEL:
+		weston_desktop_xdg_toplevel_ack_configure((struct weston_desktop_xdg_toplevel *) surface);
+		break;
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_POPUP:
+		break;
+	}
+}
+
+static void
+weston_desktop_xdg_surface_ping(struct weston_desktop_surface *dsurface,
+				uint32_t serial, void *user_data)
+{
+	struct weston_desktop_client *client =
+		weston_desktop_surface_get_client(dsurface);
+
+	zxdg_shell_v6_send_ping(weston_desktop_client_get_resource(client),
+				serial);
+}
+
+static void
+weston_desktop_xdg_surface_committed(struct weston_desktop_surface *dsurface,
+				     void *user_data, bool new_buffer,
+				     int32_t sx, int32_t sy)
+{
+	struct weston_desktop_xdg_surface *surface = user_data;
+
+	if (new_buffer && !surface->configured) {
+		wl_resource_post_error(surface->resource,
+				       ZXDG_SURFACE_V6_ERROR_UNCONFIGURED_BUFFER,
+				       "xdg_surface has never been configured");
+		return;
+	}
+
+	if (surface->has_next_geometry) {
+		surface->has_next_geometry = false;
+		weston_desktop_surface_set_geometry(surface->desktop_surface,
+						    surface->next_geometry);
+	}
+
+	switch (surface->role) {
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_NONE:
+		wl_resource_post_error(surface->resource,
+				       ZXDG_SHELL_V6_ERROR_INVALID_SURFACE_STATE,
+				       "xdg_surface must have a role");
+		break;
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_TOPLEVEL:
+		weston_desktop_xdg_toplevel_committed((struct weston_desktop_xdg_toplevel *) surface, new_buffer, sx, sy);
+		break;
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_POPUP:
+		weston_desktop_xdg_popup_committed((struct weston_desktop_xdg_popup *) surface);
+		break;
+	}
+}
+
+static void
+weston_desktop_xdg_surface_close(struct weston_desktop_surface *dsurface,
+				 void *user_data)
+{
+	struct weston_desktop_xdg_surface *surface = user_data;
+
+	switch (surface->role) {
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_NONE:
+		assert(0 && "not reached");
+		break;
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_TOPLEVEL:
+		weston_desktop_xdg_toplevel_close((struct weston_desktop_xdg_toplevel *) surface);
+		break;
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_POPUP:
+		weston_desktop_xdg_popup_close((struct weston_desktop_xdg_popup *) surface);
+		break;
+	}
+}
+
+static void
+weston_desktop_xdg_surface_destroy(struct weston_desktop_surface *dsurface,
+				   void *user_data)
+{
+	struct weston_desktop_xdg_surface *surface = user_data;
+
+	switch (surface->role) {
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_NONE:
+		break;
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_TOPLEVEL:
+		weston_desktop_xdg_toplevel_destroy((struct weston_desktop_xdg_toplevel *) surface);
+		break;
+	case WESTON_DESKTOP_XDG_SURFACE_ROLE_POPUP:
+		weston_desktop_xdg_popup_destroy((struct weston_desktop_xdg_popup *) surface);
+		break;
+	}
+
+	if (surface->configure_idle != NULL)
+		wl_event_source_remove(surface->configure_idle);
+
+	free(surface);
+}
+
+static const struct zxdg_surface_v6_interface weston_desktop_xdg_surface_implementation = {
+	.destroy             = weston_desktop_destroy_request,
+	.get_toplevel        = weston_desktop_xdg_surface_protocol_get_toplevel,
+	.get_popup           = weston_desktop_xdg_surface_protocol_get_popup,
+	.set_window_geometry = weston_desktop_xdg_surface_protocol_set_window_geometry,
+	.ack_configure       = weston_desktop_xdg_surface_protocol_ack_configure,
+};
+
+static const struct weston_desktop_surface_implementation weston_desktop_xdg_surface_internal_implementation = {
+	/* These are used for toplevel only */
+	.set_maximized = weston_desktop_xdg_toplevel_set_maximized,
+	.set_fullscreen = weston_desktop_xdg_toplevel_set_fullscreen,
+	.set_resizing = weston_desktop_xdg_toplevel_set_resizing,
+	.set_activated = weston_desktop_xdg_toplevel_set_activated,
+	.set_size = weston_desktop_xdg_toplevel_set_size,
+
+	.get_maximized = weston_desktop_xdg_toplevel_get_maximized,
+	.get_fullscreen = weston_desktop_xdg_toplevel_get_fullscreen,
+	.get_resizing = weston_desktop_xdg_toplevel_get_resizing,
+	.get_activated = weston_desktop_xdg_toplevel_get_activated,
+
+	/* These are used for popup only */
+	.update_position = weston_desktop_xdg_popup_update_position,
+
+	/* Common API */
+	.committed = weston_desktop_xdg_surface_committed,
+	.ping = weston_desktop_xdg_surface_ping,
+	.close = weston_desktop_xdg_surface_close,
+
+	.destroy = weston_desktop_xdg_surface_destroy,
+};
+
+static void
+weston_desktop_xdg_shell_protocol_create_positioner(struct wl_client *wl_client,
+						    struct wl_resource *resource,
+						    uint32_t id)
+{
+	struct weston_desktop_client *client =
+		wl_resource_get_user_data(resource);
+	struct weston_desktop_xdg_positioner *positioner;
+
+	positioner = zalloc(sizeof(struct weston_desktop_xdg_positioner));
+	if (positioner == NULL) {
+		wl_client_post_no_memory(wl_client);
+		return;
+	}
+
+	positioner->client = client;
+	positioner->desktop = weston_desktop_client_get_desktop(positioner->client);
+
+	positioner->resource =
+		wl_resource_create(wl_client,
+				   &zxdg_positioner_v6_interface,
+				   wl_resource_get_version(resource), id);
+	if (positioner->resource == NULL) {
+		wl_client_post_no_memory(wl_client);
+		free(positioner);
+		return;
+	}
+	wl_resource_set_implementation(positioner->resource,
+				       &weston_desktop_xdg_positioner_implementation,
+				       positioner, weston_desktop_xdg_positioner_destroy);
+}
+
+static void
+weston_desktop_xdg_surface_resource_destroy(struct wl_resource *resource)
+{
+	struct weston_desktop_surface *dsurface =
+		wl_resource_get_user_data(resource);
+
+	if (dsurface != NULL)
+		weston_desktop_surface_resource_destroy(resource);
+}
+
+static void
+weston_desktop_xdg_shell_protocol_get_xdg_surface(struct wl_client *wl_client,
+						  struct wl_resource *resource,
+						  uint32_t id,
+						  struct wl_resource *surface_resource)
+{
+	struct weston_desktop_client *client =
+		wl_resource_get_user_data(resource);
+	struct weston_surface *wsurface =
+		wl_resource_get_user_data(surface_resource);
+	struct weston_desktop_xdg_surface *surface;
+
+	surface = zalloc(weston_desktop_surface_role_biggest_size);
+	if (surface == NULL) {
+		wl_client_post_no_memory(wl_client);
+		return;
+	}
+
+	surface->desktop = weston_desktop_client_get_desktop(client);
+	surface->surface = wsurface;
+
+	surface->desktop_surface =
+		weston_desktop_surface_create(surface->desktop, client,
+					      surface->surface,
+					      &weston_desktop_xdg_surface_internal_implementation,
+					      surface);
+	if (surface->desktop_surface == NULL) {
+		free(surface);
+		return;
+	}
+
+	surface->resource =
+		weston_desktop_surface_add_resource(surface->desktop_surface,
+						    &zxdg_surface_v6_interface,
+						    &weston_desktop_xdg_surface_implementation,
+						    id, weston_desktop_xdg_surface_resource_destroy);
+	if (surface->resource == NULL)
+		return;
+
+	if (wsurface->buffer_ref.buffer != NULL) {
+		wl_resource_post_error(surface->resource,
+				       ZXDG_SURFACE_V6_ERROR_UNCONFIGURED_BUFFER,
+				       "xdg_surface must not have a buffer at creation");
+		return;
+	}
+}
+
+static void
+weston_desktop_xdg_shell_protocol_pong(struct wl_client *wl_client,
+				       struct wl_resource *resource,
+				       uint32_t serial)
+{
+	struct weston_desktop_client *client =
+		wl_resource_get_user_data(resource);
+
+	weston_desktop_client_pong(client, serial);
+}
+
+static const struct zxdg_shell_v6_interface weston_desktop_xdg_shell_implementation = {
+	.destroy = weston_desktop_destroy_request,
+	.create_positioner = weston_desktop_xdg_shell_protocol_create_positioner,
+	.get_xdg_surface = weston_desktop_xdg_shell_protocol_get_xdg_surface,
+	.pong = weston_desktop_xdg_shell_protocol_pong,
+};
+
+static void
+weston_desktop_xdg_shell_bind(struct wl_client *client, void *data,
+			      uint32_t version, uint32_t id)
+{
+	struct weston_desktop *desktop = data;
+
+	weston_desktop_client_create(desktop, client, NULL,
+				     &zxdg_shell_v6_interface,
+				     &weston_desktop_xdg_shell_implementation,
+				     version, id);
+}
+
+struct wl_global *
+weston_desktop_xdg_shell_v6_create(struct weston_desktop *desktop, struct wl_display *display)
+{
+	return wl_global_create(display, &zxdg_shell_v6_interface,
+				WD_XDG_SHELL_PROTOCOL_VERSION, desktop,
+				weston_desktop_xdg_shell_bind);
+}
diff --git a/libweston/compositor.c b/libweston/compositor.c
index 98c5bd6..24cfcfa 100644
--- a/libweston/compositor.c
+++ b/libweston/compositor.c
@@ -3344,6 +3344,12 @@ weston_surface_set_role(struct weston_surface *surface,
 	return -1;
 }
 
+WL_EXPORT const char *
+weston_surface_get_role(struct weston_surface *surface)
+{
+	return surface->role_name;
+}
+
 WL_EXPORT void
 weston_surface_set_label_func(struct weston_surface *surface,
 			      int (*desc)(struct weston_surface *,
diff --git a/libweston/compositor.h b/libweston/compositor.h
index 26667ca..301bdca 100644
--- a/libweston/compositor.h
+++ b/libweston/compositor.h
@@ -1526,6 +1526,8 @@ weston_surface_set_role(struct weston_surface *surface,
 			const char *role_name,
 			struct wl_resource *error_resource,
 			uint32_t error_code);
+const char *
+weston_surface_get_role(struct weston_surface *surface);
 
 void
 weston_surface_set_label_func(struct weston_surface *surface,
-- 
2.9.2



More information about the wayland-devel mailing list