[PATCH weston 2/7] weston-egl-ext.h: remove EGL_EGLEXT_PROTOTYPES sections
emil.l.velikov at gmail.com
Mon Aug 15 14:21:53 UTC 2016
On 12 August 2016 at 08:47, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Mon, 4 Jul 2016 15:27:14 +0100
> Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>> Those the function declarations alongside the EGL_EGLEXT_PROTOTYPES
>> guards. Although those are copy/paste sections from the header(s),
>> having and/or using them is a bad idea, as per the EGL spec.
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> If people like them one could keep them I, but considering they are not
>> used (and they shouldn't be used) it's better to remove them.
>> libweston/weston-egl-ext.h | 10 ----------
>> 1 file changed, 10 deletions(-)
> Hi Emil,
> it seems pretty hard to make a mind on this change. Daniel is leaning
> on kinda maybe not and I was leaning on kinda maybe yes. The policy of
> being a copy vs. not having stuff we don't use.
> I'll choose to solve this on the "copy" side. We copy whole extension
> blocks into this file regardless whether all the bits are actually used
> or not, particularly all the #defines. To follow that logic, let's drop
> this patch.
I'm in a similar pickle - keep it as a copy vs drop bad/dead code. Yet
I've opted to send this since the EGL_PLATFORM_*_KHR definitions don't
follow the former approach.
Might send a patch updating those at some point.
More information about the wayland-devel