[PATCH wayland] scanner: Correct doxygen group name for *_add_listener

Yong Bakos junk at humanoriented.com
Tue Aug 16 15:38:09 UTC 2016


On Aug 15, 2016, at 10:13 PM, Jonas Ã…dahl <jadahl at gmail.com> wrote:
> 
> On Tue, Jul 26, 2016 at 04:09:48PM -0500, Yong Bakos wrote:
>> From: Yong Bakos <ybakos at humanoriented.com>
>> 
>> From: Bill Spitzak <spitzak at gmail.com>
> 
> Should the patch author be Yong or Bill here? If a patch was authored by
> multiple parties the common way so far has been to put all those authors
> in "Signed-off-by"'s with only a single patch author (since there is
> only possible to have one).
> 
> It looks like original patch had the Signed-off-by by Bill, so I would
> it be fine if I changed the author to that while adding both of yours
> Signed-off-by?

Yes, authored by Bill with both our S-o-b's.
(Apologies for the double "from"s, I need to adjust my git send-email
config.)

Thank you,
yong


> 
> 
> Jonas
> 
>> 
>> Scanner has been generating the doxygen group label "foo_iface" for all
>> *_add_listener functions, and the label "iface_foo" everywhere else.
>> 
>> Correct the label generation, so all *_add_listener functions appear correctly
>> within doxygen output.
>> 
>> See: https://patchwork.freedesktop.org/patch/89806/
>> 
>> Signed-off-by: Yong Bakos <ybakos at humanoriented.com>
>> ---
>> src/scanner.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/src/scanner.c b/src/scanner.c
>> index d501ba7..ffd72ae 100644
>> --- a/src/scanner.c
>> +++ b/src/scanner.c
>> @@ -1362,7 +1362,7 @@ emit_structs(struct wl_list *message_list, struct interface *interface, enum sid
>> 
>> 	if (side == CLIENT) {
>> 	    printf("/**\n"
>> -		   " * @ingroup %s_iface\n"
>> +		   " * @ingroup iface_%s\n"
>> 		   " */\n", interface->name);
>> 	    printf("static inline int\n"
>> 		   "%s_add_listener(struct %s *%s,\n"
>> -- 
>> 2.7.2
>> 
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/wayland-devel



More information about the wayland-devel mailing list