[PATCH weston] Makefile.am: Fix libtool race

[Emil Velikov]

On 16 August 2016 at 09:49, Quentin Glidic
<sardemff7+wayland at sardemff7.net> wrote:
> On 16/08/2016 10:26, Pekka Paalanen wrote:
>>
>> On Mon, 15 Aug 2016 16:51:32 +0100
>> Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>
>>> On 15 August 2016 at 16:29, Quentin Glidic
>>> <sardemff7+wayland at sardemff7.net> wrote:
>>>>
>>>> From: Quentin Glidic <sardemff7+git at sardemff7.net>
>>>>
>>>> Signed-off-by: Quentin Glidic <sardemff7+git at sardemff7.net>
>>>> ---
>>>>  Makefile.am | 8 ++++++++
>>>>  1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/Makefile.am b/Makefile.am
>>>> index 6c3f4f7..1e63a58 100644
>>>> --- a/Makefile.am
>>>> +++ b/Makefile.am
>>>> @@ -61,6 +61,14 @@ CLEANFILES = weston.ini
>>>> \
>>>>         internal-screenshot-00.png              \
>>>>         $(BUILT_SOURCES)
>>>>
>>>> +# Libtool race fix
>>>> +# libweston-desktop depends on libweston, and desktop-shell depends on
>>>> both.
>>>> +# This leads to a libtool race at installation, because libtool
>>>> re-links
>>>> +# everything.
>>>> +# If you add more fixes, you may need a workaround to keep automake
>>>> generated
>>>> +# targets. See http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7328
>>>> +install-libweston_moduleLTLIBRARIES install-moduleLTLIBRARIES:
>>>> install-libLTLIBRARIES
>>>> +
>>>
>>> Or we can convince people into using slibtool - it doesn't relink ;-)
>>> Written in C, a bit faster although it's missing --uninstall atm (iirc).
>>
>>
>> Oh, never heard of it before. Might be interesting but a discussion for
>> calmer times.
>
>
> No --uninstall means no "make distcheck".
Indeed, that's how I found out about it ;-)

> It’s a shame, but distcheck needs
> an uninstall, while regular packaging just leave it to package managers, so
> replacement (for Libtool or Autotools) rarely implement it (e.g. CMake has
> no uninstall either).
>
Afaict the goal (of slibtool) is to have it implemented.

But as Pekka mentioned - that's a discussion for another day
Emil