[PATCH wayland 2/2] tests: Add test for wl_list_length

Eric Engestrom eric.engestrom at imgtec.com
Fri Aug 26 09:02:23 UTC 2016


On Thu, Aug 25, 2016 at 04:12:34PM -0700, Yong Bakos wrote:
> From: Yong Bakos <ybakos at humanoriented.com>
> 
> list-test.c did not cover wl_list_length, so add one test that specifically
> tests this method.
> 
> Signed-off-by: Yong Bakos <ybakos at humanoriented.com>
> ---
>  tests/list-test.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tests/list-test.c b/tests/list-test.c
> index 21ca4ec..0752618 100644
> --- a/tests/list-test.c
> +++ b/tests/list-test.c
> @@ -57,6 +57,19 @@ TEST(list_insert)
>  	assert(e.link.prev == &list);
>  }
>  
> +TEST(list_length)
> +{
> +	struct wl_list list;
> +	struct element e;
> +
> +	wl_list_init(&list);
> +	assert(wl_list_length(&list) == 0);
> +	wl_list_insert(&list, &e.link);
> +	assert(wl_list_length(&list) == 1);

What about a second insert(e) to make sure duplicates are handled
correctly?

With or without this, the series is
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

> +	wl_list_remove(&e.link);
> +	assert(wl_list_length(&list) == 0);
> +}
> +
>  TEST(list_iterator)
>  {
>  	struct wl_list list;
> -- 
> 2.7.2


More information about the wayland-devel mailing list