[PATCH wayland-protocols] buildsystem: add missing uninstalled pkg-config infra

Bryce Harrington bryce at osg.samsung.com
Sat Aug 27 01:06:43 UTC 2016


It is confusing terminology to call this 'uninstalled'; sounds like this
might remove something from your system.  'non-installed' would be more
accurate but isn't that great of a name either.

You should also provide an explanation about what the purpose of this is
in the changelog.  I.e. what capability does this enable.  That might
suggest a more intuitive name for this...

And also explain what this causes to be pulled in (i.e. how to determine
what protocols are made available by this package).

Also, using the term 'missing' suggests that something that was working
before is now broken without this patch, but it sounds like rather this
is adding new functionality.  If something actually is broken, please
mention that in the changelog as well, because in that case it might be
a high priority for inclusion in the release.

Bryce

On Fri, Aug 26, 2016 at 01:50:13PM -0500, Derek Foreman wrote:
> From: "Reynaldo H. Verdejo Pinochet" <reynaldo at osg.samsung.com>
> 
> Signed-off-by: Reynaldo H. Verdejo Pinochet <reynaldo at osg.samsung.com>
> Reviewed-by: Derek Foreman <derekf at osg.samsung.com>
> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> ---
>  configure.ac                        | 1 +
>  wayland-protocols-uninstalled.pc.in | 5 +++++
>  2 files changed, 6 insertions(+)
>  create mode 100644 wayland-protocols-uninstalled.pc.in
> 
> diff --git a/configure.ac b/configure.ac
> index 4c43daa..fbb0ec2 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -35,6 +35,7 @@ PKG_NOARCH_INSTALLDIR
>  AC_CONFIG_FILES([
>  	Makefile
>  	wayland-protocols.pc
> +	wayland-protocols-uninstalled.pc
>  	])
>  AC_OUTPUT
>  
> diff --git a/wayland-protocols-uninstalled.pc.in b/wayland-protocols-uninstalled.pc.in
> new file mode 100644
> index 0000000..cf7adf2
> --- /dev/null
> +++ b/wayland-protocols-uninstalled.pc.in
> @@ -0,0 +1,5 @@
> +pkgdatadir=@abs_top_srcdir@
> +
> +Name: Wayland Protocols
> +Description: Wayland protocol files (not installed)
> +Version: @WAYLAND_PROTOCOLS_VERSION@
> -- 
> 2.9.3
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list