[PATCH] Introduce keyboard grabbing protocol

[Olivier Fourdan]

Hi Giulio,

> i have a couple of comments below

Thanks a lot for your quick reply!
 
> 2016-08-30 11:54 GMT+02:00 Olivier Fourdan <ofourdan at redhat.com>:
> > [...]
> 
> I can understand the Xwayland use, but not the VM one. If i'm using a
> VM i expect it to receive key events when focused, not otherwise. If
> the point of this is just to inhibit the compositor's shortcuts than i
> think the protocol should just do that, and not do an actual grab.
> Additionally, as a user i'm not sure i would want my shortcuts to stop
> working, ever...

On X11, some VM viewer will grab the keyboard and pointer so that all input events are set to the window, with one special shortcut to release those grabs - Using the grab keyboard protocol drafted here would allow to do that in Wayland as well.

Besides, reducing the use of the keyboard grab to Xwayland only might be a tad restrictive.

> [...]
> 
> I don't think it makes sense to send errors for those, it seems like
> both cases are out of the client's direct control and as such the
> client cannot be sure to avoid them, so it should survive when they
> happen.

Oh absolutely, good point!

Cheers,
Olivier