[PATCH] xdg-shell: require popups to intersect with or be adjacent to parent surfaces

[Jonas Ådahl]

On Mon, Dec 19, 2016 at 11:56:38AM -0500, Mike Blumenkrantz wrote:
> some restrictions must be placed on this or else it becomes legal for
> the compositor to place popups in unexpected locations
> 
> Signed-off-by: Mike Blumenkrantz <zmike at osg.samsung.com>

Could be further specified further that its about window geometry and
not just the surface I guess, but this is an improvement so:

Reviewed-by: Jonas Ådahl <jadahl at gmail.com>


Jonas

> ---
>  unstable/xdg-shell/xdg-shell-unstable-v6.xml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> index e49d74f..1c0f924 100644
> --- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> +++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> @@ -118,7 +118,9 @@
>        child surface relative to a parent surface. Rules can be defined to ensure
>        the child surface remains within the visible area's borders, and to
>        specify how the child surface changes its position, such as sliding along
> -      an axis, or flipping around a rectangle.
> +      an axis, or flipping around a rectangle. These positioner-created rules are
> +      constrained by the requirement that a child surface must intersect with or
> +      be at least partially adjacent to its parent surface.
>  
>        See the various requests for details about possible rules.
>  
> @@ -941,7 +943,8 @@
>        The x and y arguments passed when creating the popup object specify
>        where the top left of the popup should be placed, relative to the
>        local surface coordinates of the parent surface. See
> -      xdg_surface.get_popup.
> +      xdg_surface.get_popup. An xdg_popup must intersect with or be at least
> +      partially adjacent to its parent surface.
>  
>        The client must call wl_surface.commit on the corresponding wl_surface
>        for the xdg_popup state to take effect.
> -- 
> 2.5.5
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel