[PATCH libinput 1/4] test: don't set LITEST_VERBOSE during make check

Hans de Goede hdegoede at redhat.com
Tue Dec 20 11:16:53 UTC 2016


Hi,

On 20-12-16 03:51, Peter Hutterer wrote:
> I've never had the log output help me identify a bug during a test run. Now
> that we run all tests in the same binary the verbosity just leads to a massive
> file that makes it hard to find the actual failure. Turn off LITEST_VERBOSE by
> default but leave the parsing in for cases where it may come in handy.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Series looks good to me and is:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans



> ---
>  test/Makefile.am | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/test/Makefile.am b/test/Makefile.am
> index 6dfc138..f43cf52 100644
> --- a/test/Makefile.am
> +++ b/test/Makefile.am
> @@ -143,8 +143,6 @@ test_build_linker_LDADD = $(top_builddir)/src/libinput.la $(top_builddir)/src/li
>  test_build_cxx_SOURCES = build-cxx.cc
>  test_build_cxx_CXXFLAGS = -Wall -Wextra -Wno-unused-parameter $(AM_CXXFLAGS)
>
> -AM_TESTS_ENVIRONMENT= LITEST_VERBOSE=1; export LITEST_VERBOSE;
> -
>  if HAVE_VALGRIND
>  VALGRIND_FLAGS=--leak-check=full \
>  	       --quiet \
>


More information about the wayland-devel mailing list