[PATCH weston v2 04/24] xwayland: detect initially positioned X11 windows

[Daniel Stone]

Hi Pekka,

On 21 December 2016 at 14:40, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> @@ -2500,6 +2510,17 @@ legacy_fullscreen(struct weston_wm *wm,
>  }
>
>  static bool
> +weston_wm_window_is_positioned(struct weston_wm_window *window)
> +{
> +       if (window->map_request_x == INT_MIN ||
> +           window->map_request_y == INT_MIN)
> +               weston_log("XWM warning: win %d did not see map request\n",
> +                          window->id);
> +
> +       return window->map_request_x != 0 || window->map_request_y != 0;
> +}

Er, doesn't this break windows explicitly positioned at the origin?
And I may be wrong, but won't OR windows avoid MapRequest to the WM,
meaning that every OR window mapped would trigger this warning?

I'd assume this should just be 'return window->map_request_x !=
INT_MIN || window->map_request_y != INT_MIN;' ...

Cheers,
Daniel