[PATCH] input: send frame after axis event in default grab

[Marek Chalupa]

On 02/01/2016 04:20 PM, Jonas Ådahl wrote:
> On Mon, Feb 01, 2016 at 04:16:17PM +0100, Marek Chalupa wrote:
>> Clients that implement version 5 of pointer wait for the frame
>> after pointer events (e. g. GTK+ clients). We send it after motion
>> and button, but not after the axis event in default grab.
>>
>> Send the frame after the axis event, but only in the default grab,
>> so that some other grabs (implementing kinetic scrolling or so)
>> can decide when to send the frame itself
>
> The way it is done now, is that the backend is responsible for emitting
> a frame event when it needs to. It'll then pass via the frame callback
> of the grab, i.e. for the default grab, the default_grab_pointer_frame
> should be called.
>
> What backend were you using where you saw this?

It was on x11-backend. You're right, it works on drm-backed, so the 
mistake will be in x11-backend.

Thanks,
Marek

>
>
> Jonas
>
>>
>> Signed-off-by: Marek Chalupa <mchqwerty at gmail.com>
>> ---
>>   src/input.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/input.c b/src/input.c
>> index 2539fa7..32ad20a 100644
>> --- a/src/input.c
>> +++ b/src/input.c
>> @@ -404,6 +404,7 @@ default_grab_pointer_axis(struct weston_pointer_grab *grab,
>>   			  struct weston_pointer_axis_event *event)
>>   {
>>   	weston_pointer_send_axis(grab->pointer, time, event);
>> +	weston_pointer_send_frame(grab->pointer);
>>   }
>>
>>   static void
>> --
>> 2.5.0
>>
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/wayland-devel