[PATCH weston 1/3] clipboard: zalloc the clipboard_source

Derek Foreman derekf at osg.samsung.com
Mon Feb 1 20:01:12 UTC 2016


On 01/02/16 01:28 PM, Carlos Garnacho wrote:
> The wrapped weston_data_source struct has new fields which were left
> uninitialized, so its access is unreliable.
> 
> Signed-off-by: Carlos Garnacho <carlosg at gnome.org>

Thanks for the quick fix on this.

Whole series is:
Reviewed-by: Derek Foreman <derekf at osg.samsung.com
and
Tested-by: Derek Foreman <derekf at osg.samsung.com>


> ---
>  src/clipboard.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/clipboard.c b/src/clipboard.c
> index da7dbb6..54a578f 100644
> --- a/src/clipboard.c
> +++ b/src/clipboard.c
> @@ -141,7 +141,7 @@ clipboard_source_create(struct clipboard *clipboard,
>  	struct clipboard_source *source;
>  	char **s;
>  
> -	source = malloc(sizeof *source);
> +	source = zalloc(sizeof *source);
>  	if (source == NULL)
>  		return NULL;
>  
> 



More information about the wayland-devel mailing list