[PATCH wayland 2/2] build: build distcheck with --enable-fatal-warnings

[Bryce Harrington]

On Wed, Feb 17, 2016 at 09:31:33AM -0600, Derek Foreman wrote:
> On 17/02/16 12:17 AM, Bryce Harrington wrote:
> > On Fri, Jan 15, 2016 at 01:33:53PM -0600, Derek Foreman wrote:
> >> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> > 
> > Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>
> > 
> > And pushed both patches in series:
> > 
> > To ssh://git.freedesktop.org/git/wayland/wayland
> >    88ff135..8125919  master -> master
> > 
> > I wanted to land these two post-release because while they work just
> > fine on my own systems, who knows what warnings might turn up on other
> > systems/compilers so wanted a full release cycle to allow everyone
> > maximum testing for testing.
> > 
> > If it turns out there are warnings that can't be addressed in time for
> > 1.11 for whatever reason, we may need to disable this at least for that
> > release.  But I'm betting it won't come to that.
> 
> Worked fine for me too, but already broke on gentoo and arch.

Well that was even faster than I expected.  Thanks for tending to it.

> As discussed on irc since, I've reverted my patch that enables fatal
> warnings for distcheck, as it broke for quite a few devs.  Going forward
> we'll just ask people to pretty please turn on --enable-fatal-warnings
> to check their own work before submitting patches.

Oh yeah that'll never happen.  ;-)

But there was talk about setting up CI in relation to establishing the
github mirror, no?  Perhaps that would be a more realistic place for
switching that on, so we do catch this sort of stuff?

> Turns out wayland/tests/test-runner.c's debugger detector doesn't check
> return values for read() and write().  sigh. :)

That's worth fixing (and I suppose you're already working on it).  Were
there other warnings this exercise scared up?

Bryce

> Thanks,
> Derek
> 
> > Bryce
> > 
> >> ---
> >>  Makefile.am | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/Makefile.am b/Makefile.am
> >> index e850abc..5e5576e 100644
> >> --- a/Makefile.am
> >> +++ b/Makefile.am
> >> @@ -11,6 +11,8 @@ AM_CPPFLAGS =					\
> >>  
> >>  AM_CFLAGS = $(GCC_CFLAGS)
> >>  
> >> +AM_DISTCHECK_CONFIGURE_FLAGS = --enable-fatal-warnings
> >> +
> >>  aclocaldir = $(datadir)/aclocal
> >>  dist_aclocal_DATA = wayland-scanner.m4
> >>  
> >> -- 
> >> 2.7.0.rc3
> >>
> >> _______________________________________________
> >> wayland-devel mailing list
> >> wayland-devel at lists.freedesktop.org
> >> http://lists.freedesktop.org/mailman/listinfo/wayland-devel