[PATCH weston v2 2/2] configure: Make jpeglib an optional dependency.
bryce at osg.samsung.com
Wed Feb 17 19:04:16 UTC 2016
On Wed, Feb 17, 2016 at 12:28:48PM +0100, Emmanuel Gil Peyrot wrote:
> On Tue, Feb 16, 2016 at 10:29:34PM -0800, Bryce Harrington wrote:
> > On Tue, Feb 16, 2016 at 01:57:52AM +0000, Emmanuel Gil Peyrot wrote:
> > > It doesn’t make sense to fail the entire build when jpeglib isn’t
> > > present, so this commit makes it optional just like libwebp in the
> > > previous one, disabled with --without-jpeg and forced with --with-jpeg.
> > >
> > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve at linkmauve.fr>
> > Is there any functional loss when jpg support is missing?
> Yes, Weston as a whole loses the ability to load JPEG files, be it in
> weston-image, in icons, or maybe more importantly in the background.
> There is no JPEG image being installed by Weston though, so only
> user-installed images would break.
Ok, yeah that's about what you'd expect. The patch looks technically
fine to me, and presuming there's no other more fundamental lossage
Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>
Out of curiousity does this solve a particular issue you're aware of, or
is this just for symmetry with the webp build control?
More information about the wayland-devel