[PATCH weston v2] hmi-controller: remove duplicate commit_changes in random mode

Wataru Natsume wataru_natsume at xddp.denso.co.jp
Wed Feb 17 23:48:40 UTC 2016


From: Wataru Natsume <WATARU_NATSUME at xddp.denso.co.jp>

Previous code cleaned up surfaces in layer once and then added
surfaces to a layer in random. In this flow, two commitchanges are
required.

Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA at xddp.denso.co.jp>
[WATARU_NATSUME at xddp.denso.co.jp: Removes unnecessary check]
Signed-off-by: Wataru Natsume <WATARU_NATSUME at xddp.denso.co.jp>

---
Changes from v1 - Removes unnecessary check if the surface is on a layer.

 ivi-shell/hmi-controller.c |    9 ---------
 1 file changed, 9 deletions(-)

diff --git a/ivi-shell/hmi-controller.c b/ivi-shell/hmi-controller.c
index 8da3d3c..ace6555 100644
--- a/ivi-shell/hmi-controller.c
+++ b/ivi-shell/hmi-controller.c
@@ -424,18 +424,9 @@ mode_random_replace(struct hmi_controller *hmi_ctrl,
 
 	wl_list_for_each(application_layer, layer_list, link) {
 		layers[layer_idx] = application_layer;
-		ivi_layout_interface->layer_set_render_order(layers[layer_idx]->ivilayer,
-							NULL, 0);
 		layer_idx++;
 	}
 
-	/*
-	 * This commit change is needed because ivisurface can not belongs to several layers
-	 * at the same time. So ivisurfaces shall be removed from layers once and then set them
-	 * to layers randomly.
-	 */
-	ivi_layout_interface->commit_changes();
-
 	for (i = 0; i < surface_length; i++) {
 		ivisurf = pp_surface[i];
 
-- 
1.7.9.5



More information about the wayland-devel mailing list