[PATCH] libinput-device: Remove unnecessary function call

Chris Michael cpmichael at osg.samsung.com
Fri Feb 19 16:07:00 UTC 2016


When we handle pointer button events, we already retrieve the button
state at the top of this function, so there is no real need to call
the same function again as we can just reuse the 'button_state'
variable that we have above.

Signed-off-by: Chris Michael <cpmichael at osg.samsung.com>
---
 src/libinput-device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/libinput-device.c b/src/libinput-device.c
index 99b2916..78b0ac9 100644
--- a/src/libinput-device.c
+++ b/src/libinput-device.c
@@ -154,7 +154,8 @@ handle_pointer_button(struct libinput_device *libinput_device,
 	notify_button(device->seat,
 		      libinput_event_pointer_get_time(pointer_event),
 		      libinput_event_pointer_get_button(pointer_event),
-		      libinput_event_pointer_get_button_state(pointer_event));
+                      button_state);
+
 	return true;
 }
 
-- 
2.7.0



More information about the wayland-devel mailing list