[PATCH] libinput-device: Remove unnecessary function call

Bryce Harrington bryce at osg.samsung.com
Tue Feb 23 00:14:56 UTC 2016


On Mon, Feb 22, 2016 at 08:47:24AM -0500, Chris Michael wrote:
> When we handle keyboard key events, we already retrieve the key state
> at the top of this function, so there is no real need to call the same
> libinput function again as we can just reuse the 'key_state' variable
> that we have above.
> 
> Signed-off-by: Chris Michael <cpmichael at osg.samsung.com>

Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>

> ---
>  src/libinput-device.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/libinput-device.c b/src/libinput-device.c
> index 78b0ac9..f8b614a 100644
> --- a/src/libinput-device.c
> +++ b/src/libinput-device.c
> @@ -76,8 +76,7 @@ handle_keyboard_key(struct libinput_device *libinput_device,
>  	notify_key(device->seat,
>  		   libinput_event_keyboard_get_time(keyboard_event),
>  		   libinput_event_keyboard_get_key(keyboard_event),
> -		   libinput_event_keyboard_get_key_state(keyboard_event),
> -		   STATE_UPDATE_AUTOMATIC);
> +		   key_state, STATE_UPDATE_AUTOMATIC);
>  }
>  
>  static bool
> -- 
> 2.7.0
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list