[PATCH weston 7/7] protocol: migrate to stable presentation-time.xml
bryce at osg.samsung.com
Tue Feb 23 18:29:45 UTC 2016
On Tue, Feb 23, 2016 at 02:19:32PM +0200, Pekka Paalanen wrote:
> > > diff --git a/configure.ac b/configure.ac
> > > index 276584f..92eaa3c 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -181,6 +181,7 @@ fi
> > > PKG_CHECK_MODULES(LIBINPUT_BACKEND, [libinput >= 0.8.0])
> > > PKG_CHECK_MODULES(COMPOSITOR, [$COMPOSITOR_MODULES])
> > >
> > > +# XXX: wayland-protocols needs a version bump for stable/presentation-time.
> > > PKG_CHECK_MODULES(WAYLAND_PROTOCOLS, [wayland-protocols >= 1.0],
> > > [ac_wayland_protocols_pkgdatadir=`$PKG_CONFIG --variable=pkgdatadir wayland-protocols`])
> > > AC_SUBST(WAYLAND_PROTOCOLS_DATADIR, $ac_wayland_protocols_pkgdatadir)
> > For what it's worth, the ideal place to put notes for the release
> > manager is at the very top of the file, near where the version number
> > is. That's the only place in the file that we can be 100% certain will
> > be looked at during review time.
> That's a good idea, I can move it there. Seems to be easy to find the
> place where to edit.
> > If you want to formalize this a bit, and we're not doing the .90 on
> > wayland-protocols (which I still think is a fair idea), we could
> > have these notes placed somewhere specifically, and either document in
> > releasing.txt to check for notes, or even cause 'make dist' refuse to
> > operate if these notes exist.
> Making 'make dist' or distcheck to fail is an excellent idea. It could
> grep configure.ac for 'RELEASE_BLOCKER' for instance, and then one
> would just put that string in the comment anywhere.
> There just one problem: people want to be able to run distcheck, and
> dist is a dependency on distcheck, I believe. So we'd need an option to
> avoid the check until release time, but... it's getting awkward.
I'm sure there's a definable hook or way to script it to only occur with
actual releases, but yeah unless this becomes a common thing it's
probably not worth the bother. The note at the top of configure.ac is
adequate for now.
More information about the wayland-devel