[PATCH v2] server: Calculate remaining data size after a closure is processed

[Jaeyoon Jung]

> -----Original Message-----
> From: wayland-devel [mailto:wayland-devel-bounces at lists.freedesktop.org] On
> Behalf Of Jonas Adahl
> Sent: Tuesday, January 12, 2016 12:27 PM
> To: Jaeyoon Jung
> Cc: wayland-devel at lists.freedesktop.org
> Subject: Re: [PATCH v2] server: Calculate remaining data size after a closure
> is processed
> 
> On Tue, Jan 12, 2016 at 08:22:56AM +0900, Jaeyoon Jung wrote:
> > When processing a closure, data in the connection can be consumed again
> > if the closure itself invokes extra event dispatch. In that case the
> > remaining data size is also altered, so the variable len should be
> > updated after the closure is processed.
> >
> > Signed-off-by: Jaeyoon Jung <jaeyoon.jung at lge.com>
> 
> I don't like the name wl_connection_size (wl_connection_pending_input()
> or something would be more descriptive).

I just wanted to have a shorter name. wl_connection_pending_input() looks better to me as well, and I'll update the patch accordingly. Thanks.

 
> A good follow up would be a test case where this would otherwise cause
> issues. I assume it would be triggered by a wl_event_loop_dispatch() in
> a interface request handler?

Yes, exactly.

--
Jaeyoon (Jay) Jung (정재윤)
Software Platform Lab / Corporate R&D / LG Electronics