[PATCH wayland 1/2] server: improve failure log message for wl_global_create()

Derek Foreman derekf at osg.samsung.com
Thu Jan 14 09:02:17 PST 2016


The gratuitous %m jammed onto the end of the string prints errno
concatenated with the word "version".

I've removed the %m, and printed some additional information about the
failure.

Also, reversed the order of the expressions in the conditional to
make it match the english in the log message.

Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
---
 src/wayland-server.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/wayland-server.c b/src/wayland-server.c
index 2cfbb4a..c129b7d 100644
--- a/src/wayland-server.c
+++ b/src/wayland-server.c
@@ -908,9 +908,10 @@ wl_global_create(struct wl_display *display,
 	struct wl_global *global;
 	struct wl_resource *resource;
 
-	if (interface->version < version) {
-		wl_log("wl_global_create: implemented version higher "
-		       "than interface version%m\n");
+	if (version > interface->version) {
+		wl_log("wl_global_create: implemented version for '%s' "
+		       "higher than interface version (%d > %d)\n",
+		       interface->name, version, interface->version);
 		return NULL;
 	}
 
-- 
2.7.0.rc3



More information about the wayland-devel mailing list