[PATCH wayland 3/3] tests: Test proxy versions

Pekka Paalanen ppaalanen at gmail.com
Thu Jan 14 23:27:51 PST 2016


On Thu, 14 Jan 2016 16:13:53 -0600
Derek Foreman <derekf at osg.samsung.com> wrote:

> On 14/01/16 02:34 AM, Pekka Paalanen wrote:
> > Oh wait!
> > 
> > One more thing...
> > 
> > On Thu, 14 Jan 2016 10:28:32 +0200
> > Pekka Paalanen <ppaalanen at gmail.com> wrote:
> >   
> >> On Tue, 12 Jan 2016 16:28:47 -0600
> >> Derek Foreman <derekf at osg.samsung.com> wrote:
> >>  
> >>> Add a test that confirms that proxy versions are always 0 for display
> >>> and correct otherwise.
> >>>
> >>> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> >>> ---
> >>>  tests/display-test.c | 41 +++++++++++++++++++++++++++++++++++++++++
> >>>  1 file changed, 41 insertions(+)

> >>
> >> Hi Derek,
> >>
> >> yup, this is half of the minimal testing I was craving for. This test
> >> is checking that the version bound in wl_registry.bind gets recorded
> >> correctly.
> >>
> >> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

> >> Yet another future work item would be to add a test that explicitly
> >> uses the unversioned libwayland-client ABI to mimic "a software
> >> component built with old protocol headers" and check the wl_pointer
> >> version comes back as zero.  
> 
> Right - that's the hardest of the bunch, I think?  To do this in a
> not-completely-contrived fashion I'd have to check in an old generated
> header file to build against? :/

Just look at how things were generated in the old version and copy the
needed function or few into the test with new names. I don't think
there is need to check in a whole header or anything more complicated.

The base libwayland-client ABI is described by the non-generated
headers, you are allowed to use them without the "official" C bindings
(generated headers).


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20160115/80e23371/attachment-0001.sig>


More information about the wayland-devel mailing list