[PATCH wayland-protocols] text: Create second version of text input protocol

Daiki Ueno ueno at gnu.org
Thu Jan 28 04:05:45 PST 2016


Hello,

Jan Arne Petersen <janarne at gmail.com> writes:

> Fixes some shortcomings of the first version:
>
> * Use only one wp_text_input per wl_seat (client side should be
>   handled by client toolkit)
> * Allow focus tracking without wl_keyboard present

These sound nice.

> * Improve update state handling
> * Allow state requests

I have a few comments regarding them, inlined below.

> +      Serials are used to synchronize the state between the text input and
> +      an input method. New serials are sent by the text input in the
> +      commit_state request and are used by the input method to indicate

There is no commit_state request anymore.

> +    <event name="request_surrounding_text">
> +      <description summary="request surrounding text from client">
> +	Request to get the surrounding text and cursor position sent from the client.
> +      </description>
> +      <arg name="serial" type="uint" summary="serial of the latest known text input state"/>
> +      <arg name="flags" type="uint"/>
> +      <arg name="before_cursor" type="int"/>
> +      <arg name="after_cursor" type="int"/>
> +    </event>
> +    <event name="request_state">
> +      <description summary="request state from client">
> +	Request to get the surrounding text and cursor position sent from the client.
> +      </description>
> +      <arg name="serial" type="uint" summary="serial of the latest known text input state"/>
> +      <arg name="flags" type="uint"/>
> +    </event>

These events have the same description.  Would you mind explaining how
they are supposed to be used, maybe in combination with the
set_surrounding_text request?

Thanks,
-- 
Daiki Ueno


More information about the wayland-devel mailing list