[PATCH weston 5/6] libweston: do not add libweston-$version to the Cflags

[Quentin Glidic]

On 04/07/2016 16:23, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> When managing headers there's normally two ways to handle them
> - with or without the subfolder.
>
> Opting for the latter case here, since it will provide direct feedback,
> whether one is using libweston-0 or any other version.
>
> Which in turn should deter (help prevent) issues like building/linking
> against multiple versions of libweston.
>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

I really prefer not to do that. It means supporting multiple versions of 
libweston will lead to a really big #ifdef dance at the top of the file 
to include every single version you might support, instead of a just a 
few #ifdef around specific new/old functions you use.

NAK for me.


Cheers,

> ---
>  libweston/libweston.pc.in | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libweston/libweston.pc.in b/libweston/libweston.pc.in
> index 24fe813..bb95af9 100644
> --- a/libweston/libweston.pc.in
> +++ b/libweston/libweston.pc.in
> @@ -2,11 +2,10 @@ prefix=@prefix@
>  exec_prefix=@exec_prefix@
>  libdir=@libdir@
>  includedir=@includedir@
> -pkgincludedir=${includedir}/libweston- at LIBWESTON_ABI_VERSION@
>
>  Name: libweston API
>  Description: Header files for libweston compositors development
>  Version: @WESTON_VERSION@
>  Requires.private: wayland-server pixman-1 xkbcommon
> -Cflags: -I${pkgincludedir}
> +Cflags: -I${includedir}
>  Libs: -L${libdir} -lweston- at LIBWESTON_ABI_VERSION@
>


-- 

Quentin “Sardem FF7” Glidic