[PATCH weston 2/2] automake: add missing git-version.h dependency

Quentin Glidic sardemff7+wayland at sardemff7.net
Tue Jul 5 12:18:16 UTC 2016

On 04/07/2016 15:57, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> compositor/main.c depends on the header, while the dependency isn't
> specified. Thus depending on the order of how things are build we could
> get a build failure.
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Strictly speaking one could resolve this (and future) issue, by not
> pushing everything from BUILT_SOURCES into CLEANFILES, but I'll leave
> that to someone more familiar with why things are as is.

The better way is to remove stuff from BUILT_SOURCES and add specific 
dependencies (as this patch does).
BUILT_SOURCES has the (big, IMO) downside that you cannot build only one 
target in a clean tree.

I’d prefer dependencies for the actual .o instead of the source file, 
but I guess that’ll do it for now.

Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>



Quentin “Sardem FF7” Glidic

More information about the wayland-devel mailing list