[PATCH weston] gl-renderer: Silence silly warning

Yong Bakos junk at humanoriented.com
Sat Jul 9 22:09:48 UTC 2016


On Jul 4, 2016, at 7:00 AM, Quentin Glidic <sardemff7+wayland at sardemff7.net> wrote:
> 
> From: Quentin Glidic <sardemff7+git at sardemff7.net>
> 
> Signed-off-by: Quentin Glidic <sardemff7+git at sardemff7.net>

Seems trivial enough, and is

Reviewed-by: Yong Bakos <ybakos at humanoriented.com>

However, it would be nice to see what the warning is in the
commit log. I can't reproduce the 'silly warning'.
There are additional cases of uninitialized local bool vars
elsewhere, that, if causing a similar warning, could also be
fixed in this patch or a short series.

yong


> ---
> libweston/gl-renderer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c
> index 28c0b50..73b6ccc 100644
> --- a/libweston/gl-renderer.c
> +++ b/libweston/gl-renderer.c
> @@ -455,7 +455,7 @@ static int
> compress_bands(pixman_box32_t *inrects, int nrects,
> 		   pixman_box32_t **outrects)
> {
> -	bool merged;
> +	bool merged = false;
> 	pixman_box32_t *out, merge_rect;
> 	int i, j, nout;
> 
> -- 
> 2.9.0
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel



More information about the wayland-devel mailing list