[PATCH libinput 0/6] Return value cleanup

Peter Hutterer peter.hutterer at who-t.net
Wed Jul 20 01:46:03 UTC 2016

On Tue, Jul 19, 2016 at 01:05:08PM -0700, Yong Bakos wrote:
> Hi Peter,
> > On Jul 18, 2016, at 5:49 PM, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> > 
> > 
> > Return values are a bit messy, we randomly use bool and int. Functions
> > returning int sometimes return 0 or 1, sometimes 0 and -1, etc. This set
> > cleans up a bit, mostly by switching a bunch of functions to just be void
> > and the rest to actual bool true/false returns (with renames where needed
> > for obviousness)
> Other than the trailing return in 2/6, looks good to me. I would explicitly
> add the includes for stdbool, but that's at your discretion.

they're already included in evdev.h and evdev-mt-touchpad.h - we need them
for the declarations. IMO we don't need to explicitly include them in the
source files then (this would be a cleanup for those files where we do so
> > No functional changes, should be an easy review for a rainy day.
> Or to procrastinate other work...
> With my comments above in mind, this is
> Reviewed-by: Yong Bakos <ybakos at humanoriented.com>

thanks, much appreciated


More information about the wayland-devel mailing list