[PATCH wayland-protocols v4 5/7] xdg-shell: Make get_popup take a xdg_surface instead of wl_surface

[Quentin Glidic]

On 24/06/2016 08:47, Jonas Ådahl wrote:
> The reason for using wl_surface before was that xdg_popup and
> xdg_surface (now xdg_toplevel) had no common interface other than
> wl_surface, but since xdg_surface is now the base interface, lets use
> that.
>
> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> Reviewed-by: Mike Blumenkrantz <zmike at osg.samsung.com>
> Reviewed-by: Yong Bakos <ybakos at humanoriented.com>
> Reviewed-by: Benoit Gschwind <gschwind at gnu-log.net>
> ---

Really neat, avoids a few checks:
Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>

Cheers,


>
> No changes since v3.
>
>  unstable/xdg-shell/xdg-shell-unstable-v6.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> index fc41485..e4d552c 100644
> --- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> +++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> @@ -171,7 +171,7 @@
>  	xdg_popup is and how it is used.
>        </description>
>        <arg name="id" type="new_id" interface="zxdg_popup_v6"/>
> -      <arg name="parent" type="object" interface="wl_surface"/>
> +      <arg name="parent" type="object" interface="zxdg_surface_v6"/>
>        <arg name="seat" type="object" interface="wl_seat" summary="the wl_seat of the user event"/>
>        <arg name="serial" type="uint" summary="the serial of the user event"/>
>        <arg name="x" type="int"/>
>


-- 

Quentin “Sardem FF7” Glidic