[PATCH weston 1/2] automake: list the the builddir include before the srcdir

[Emil Velikov]

On 5 July 2016 at 13:16, Quentin Glidic <sardemff7+wayland at sardemff7.net> wrote:
> On 04/07/2016 15:57, Emil Velikov wrote:
>>
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> Otherwise we'll pick up the stale (in-tree) generated source(s) over the
>> fresh (out-of-tree) ones.
>>
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> ---
>> It's quite a corner case, although it could save you a lot of time
>> debugging.
>> ---
>
>
> If the source directory is in a configured state, the configure script will
> refuse to configure an out-of-tree build. That means these files are
> leftovers from either a previous build or the dist tarball, I guess.
> In both cases, they should be added to CLEANFILES or DISTCLEANFILES.
>
> In the meantime, this fix is not bad:
> Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>
>

The issue is present when working with git as well:
 - Attempt/do an in-tree build or otherwise generate the files.
 - Forget that the files are around and attempt and out-of tree build.
 - Boom.

Whether to add them to CLEANFILES or DISTCLEANFILES depends on the
policy adopted by the project. I've seen some which prefer to _keep_
all the generated files on make clean. Others do that only for release
tarballs, while others...

> In the meantime, this fix is not bad:
> Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>
>
Hope that's the British definition of "not bad" :-)

Thanks
Emil