[PATCH weston 2/2] automake: add missing git-version.h dependency

Emil Velikov emil.l.velikov at gmail.com
Fri Jul 22 12:55:12 UTC 2016

On 6 July 2016 at 12:52, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 5 July 2016 at 13:18, Quentin Glidic <sardemff7+wayland at sardemff7.net> wrote:
>> On 04/07/2016 15:57, Emil Velikov wrote:
>>> From: Emil Velikov <emil.velikov at collabora.com>
>>> compositor/main.c depends on the header, while the dependency isn't
>>> specified. Thus depending on the order of how things are build we could
>>> get a build failure.
>>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>>> ---
>>> Strictly speaking one could resolve this (and future) issue, by not
>>> pushing everything from BUILT_SOURCES into CLEANFILES, but I'll leave
>>> that to someone more familiar with why things are as is.
>> The better way is to remove stuff from BUILT_SOURCES and add specific
>> dependencies (as this patch does).
>> BUILT_SOURCES has the (big, IMO) downside that you cannot build only one
>> target in a clean tree.
>> I’d prefer dependencies for the actual .o instead of the source file, but I
>> guess that’ll do it for now.
> Indeed using "file.$(OBJEXT): $generated_file" is the better option
> for simple (such as weston) projects. Once you get into generated
> header(s) which are included (directly or indirectly) in multiple
> compilation units things start getting crazy very fast. For those one
> can use BUILT_SOURCES.
> That said, I'm merely following the example(s) set in the existing build ;-)
>> Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>
Without this patch using `make -j2' consistently fails on all my
systems. Can we get it (or any alternative) merged please ?


More information about the wayland-devel mailing list