[PATCH weston 0/9] Finalise EGL/GL define(s) rework

Daniel Stone daniel at fooishbar.org
Fri Jul 22 15:20:45 UTC 2016


On 22 July 2016 at 10:57, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 4 July 2016 at 15:34, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> This series depends on "EGL/GL definitions cleanup" and does a couple of
>> things:
>>  - makes sure that we consistently use check_extension over strstr for
>> extension checking, as the latter might trigger false positives.
>>  - The remainder of the fall-back definitions has been moved to
>> weston-egl-ext.h and reused throughout the tree.
>> Hopefully I haven't lost my marbles with any of these. But if I did
>> please, don't be shy and be blunt :-)
> Humble ping ?

For both series, I landed all but the bit which removed the function
prototype defines; I kind of like that it makes it more obvious that
it's copy & pasted from upstream headers. Though it is certainly a bad
idea ... I'd be happy to see it applied, but held off for now.

I also changed weston_check_extension() to be less ambiguous:
weston_check_egl_extension(). This meant a couple of the commit titles
got rewritten as well.

Whilst I was at it, I landed the two patches that Quentin had already
reviewed as well.



More information about the wayland-devel mailing list