[PATCH wayland-protocols 2/3] xdg-shell: Clarify focus semantics for popup grabs

[Yong Bakos]

Hi Jonas,

On Jul 21, 2016, at 11:59 PM, Jonas Ådahl <jadahl at gmail.com> wrote:
> 
> On Wed, Jul 20, 2016 at 11:07:50AM -0700, Yong Bakos wrote:
>> Hi Jonas,
>> 
>>> On Jul 15, 2016, at 2:37 AM, Jonas Ådahl <jadahl at gmail.com> wrote:
>>> 
>>> Make it clearer what the focus semantics are during a popup grab. In
>>> short, when a grabbing popup is mapped, the top most popup will always
>>> have keyboard focus, while pointer and touch focus works just as normal
>>> except that only surfaces from the grabbing client will receive pointer
>>> and touch focus.
>>> 
>>> This patch doesn't really change any semantics but rather clarifies
>>> what was ambiguous before.
>>> 
>>> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
>>> ---
>>> unstable/xdg-shell/xdg-shell-unstable-v6.xml | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>> 
>>> diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
>>> index 862e664..644dbc2 100644
>>> --- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml
>>> +++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
>>> @@ -1002,10 +1002,10 @@
>>> 	popup will be immediately dismissed. If the parent is a popup that did
>>> 	not take an explicit grab, an error will be raised.
>>> 
>>> -	Clients will receive events for all their surfaces during this grab
>>> -	(which is an "owner-events" grab in X11 parlance). This is done so that
>>> -	users can navigate through submenus and other "nested" popup windows
>>> -	without having to dismiss the topmost popup.
>>> +	During an popup grab, the client owning the grab will receive pointer
>>> +	and touch events for all their surfaces as normal (similar to an
>>> +	"owner-events" grab in X11 parlance), while the top most grabbing popup
>>> +	will always have keyboard focus.
>> 
>> The sentence is definitely more succinct and clear, but I also feel that the
>> example (navigating through submenus) helps illustrate the purpose and usage.
> 
> Then how about leaving that sentence in the end, ending up with this:
> 
> 	During an popup grab, the client owning the grab will receive pointer
> 	and touch events for all their surfaces as normal (similar to an
> 	"owner-events" grab in X11 parlance), while the top most grabbing popup
> 	will always have keyboard focus. This is done so that users can
> 	navigate through submenus and other "nested" popup windows
> 	without having to dismiss the topmost popup.
> 
> Does that make it clearer?

Yep. (nit: During a popup grab)

yong


> 
> Jonas
> 
>> 
>> yong
>> 
>> 
>>>      </description>
>>> 
>>>      <arg name="seat" type="object" interface="wl_seat"
>>> -- 
>>> 2.7.4
>>> 
>>> _______________________________________________
>>> wayland-devel mailing list
>>> wayland-devel at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
>> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel