[PATCH weston v2 8/8] Create a libweston-0.so

[Quentin Glidic]

On 01/06/2016 20:43, Giulio Camuffo wrote:
> This commit also adds a libweston-0.pc file. The -0 is the abi version
> introduced in the previous patch.
>
> Signed-off-by: Giulio Camuffo <giuliocamuffo at gmail.com>
> ---
>  Makefile.am         | 45 +++++++++++++++++++++++++++------------------
>  configure.ac        |  4 ++++
>  src/libweston.pc.in | 12 ++++++++++++
>  src/weston.pc.in    |  2 +-
>  4 files changed, 44 insertions(+), 19 deletions(-)
>  create mode 100644 src/libweston.pc.in
>

One tiny comment on this one. We are getting really close to a real 
libweston!


> [snip]
> diff --git a/src/weston.pc.in b/src/weston.pc.in
> index f2ffc9e..4c5e965 100644
> --- a/src/weston.pc.in
> +++ b/src/weston.pc.in
> @@ -8,5 +8,5 @@ pkglibexecdir=${libexecdir}/@PACKAGE@
>  Name: Weston Plugin API
>  Description: Header files for Weston plugin development
>  Version: @WESTON_VERSION@
> -Requires.private: wayland-server pixman-1 xkbcommon
> +Requires.private: libweston- at LIBWESTON_ABI_VERSION@
>  Cflags: -I${includedir}/weston -I{includedir}/libweston- at LIBWESTON_ABI_VERSION@
>

Just drop the libweston includedir in Cflags, it is covered by the 
Requires.private.

With that change:
Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>

Cheers,

-- 

Quentin “Sardem FF7” Glidic