[PATCH weston v2 5/8] libinput: don't use weston_config when configuring input devices

[Pekka Paalanen]

On Thu, 2 Jun 2016 10:44:17 +0200
Quentin Glidic <sardemff7+wayland at sardemff7.net> wrote:

> On 01/06/2016 20:43, Giulio Camuffo wrote:
> > Instead add callbacks to the drm and fbdev backends and pass that to
> > the input backens so that when a new device needs to be configured
> > that is called and the compositor can configure it.
> >
> > Signed-off-by: Giulio Camuffo <giuliocamuffo at gmail.com>
> > ---
> >  Makefile.am            |  3 ++-
> >  src/compositor-drm.c   |  3 ++-
> >  src/compositor-drm.h   | 11 +++++++++++
> >  src/compositor-fbdev.c |  3 ++-
> >  src/compositor-fbdev.h | 11 +++++++++++
> >  src/compositor-rpi.c   |  2 +-
> >  src/libinput-device.c  | 31 +------------------------------
> >  src/libinput-device.h  |  2 ++
> >  src/libinput-seat.c    |  7 ++++++-
> >  src/libinput-seat.h    |  9 ++++++++-
> >  src/main.c             | 27 +++++++++++++++++++++++++++
> >  11 files changed, 73 insertions(+), 36 deletions(-)
> >  
> 
> Just one comment (applying three times to this patch).
> 
> 
>  > [snip]
> > diff --git a/src/compositor-drm.h b/src/compositor-drm.h
> > index 3f150db..1266031 100644
> > --- a/src/compositor-drm.h
> > +++ b/src/compositor-drm.h
> > @@ -36,6 +36,8 @@ extern "C" {
> >
> >  #define WESTON_DRM_BACKEND_CONFIG_VERSION 1
> >
> > +struct libinput_device;
> > +  
> 
> I guess the idea is to avoid #include <libinput.h> here. Is that really 
> a problem?

Hi,

I'm fine with the forward declaration.

Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160602/3e6c63aa/attachment.sig>