[PATCH] scanner: Fix reported executable name to 'wayland-scanner'

Peter Hutterer peter.hutterer at who-t.net
Mon Jun 6 22:03:36 UTC 2016


On Mon, Jun 06, 2016 at 10:41:04AM -0700, Bryce Harrington wrote:
> On Fri, Jun 03, 2016 at 07:33:09PM +1000, Peter Hutterer wrote:
> > On Fri, Jun 03, 2016 at 09:16:43AM +0800, Jonas Ã…dahl wrote:
> > > On Thu, Jun 02, 2016 at 02:42:44PM -0700, Bryce Harrington wrote:
> > > > 'wayland-scanner -v' (correctly) reports the program as named
> > > > "wayland-scanner", but 'wayland-scanner -h' was inconsistent, referring
> > > > to it as './scanner'.
> > > > 
> > > > Signed-off-by: Bryce Harrington <bryce at osg.samsung.com>
> > > 
> > > I guess we could also pass argv and use argv[0], but this works as well.
> > 
> > can't we use program_invocation_short_name here? or is that to GNU-ish?
> 
> We appear to be using that in weston, but I'm not seeing prior usage of
> it in wayland.  I'm guessing platform compatibility considerations are
> stronger for wayland than weston, particularly for the scanner since it
> needs to work everywhere we expect the protocols to be used; whereas in
> weston if the demo clients don't work on certain platforms it isn't the
> end of the world.

git grep _GNU_SOURCE  shows it's defined in a number of source files, so I
think we might as well go for it.

Cheers,
   Peter


More information about the wayland-devel mailing list