[PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter

[Pekka Paalanen]

On Tue, 10 May 2016 12:56:41 +0300
Pekka Paalanen <ppaalanen at gmail.com> wrote:

> On Fri, 6 May 2016 15:07:19 +0300
> Pekka Paalanen <ppaalanen at gmail.com> wrote:
> 
> > On Thu, 5 May 2016 15:46:46 -0700
> > Bryce Harrington <bryce at osg.samsung.com> wrote:
> >   
> > > On Wed, May 04, 2016 at 05:33:10PM -0700, Bryce Harrington wrote:    
> > > > On Tue, Apr 26, 2016 at 03:50:52PM +0300, Pekka Paalanen wrote:      
> > > > > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > > > > 
> > > > > Hi,
> > > > > 
> > > > > here is the v3 of the stabilization series, which I hope to the final to be
> > > > > merged.
> > > > > 
> > > > > The wayland-protocols patches are essentially the same as v2, except few
> > > > > cosmetic changes as suggested by review comments. There are mentioned in the
> > > > > review log in each patch, if there were any.
> > > > > 
> > > > > The weston patches are v3 too, though v2 was never posted. The changes to v1
> > > > > are:
> > > > > - patches 6-7 are new (simple preparation)
> > > > > - patches 8-12 are the same as v1
> > > > > - patches 13-17 are new, accounting for the spec changes from
> > > > >   wayland-protocols v1
> > > > > 
> > > > > Note, that there are now tests for the wp_viewporter API. \o/
> > > > > 
> > > > > 
> > > > > Wayland-protocols:
> > > > > 
> > > > > Pekka Paalanen (5):
> > > > >   stable: add viewporter draft
> > > > >   stable/viewporter: remove wp_viewport.set request
> > > > >   stable/viewporter: rename and build
> > > > >   stable/viewporter: rephrase a wp_viewport paragraph
> > > > >   stable/viewporter: add more error cases
> > > > > 
> > > > >  Makefile.am                      |   1 +
> > > > >  stable/viewporter/README         |   7 ++
> > > > >  stable/viewporter/viewporter.xml | 189 +++++++++++++++++++++++++++++++++++++++
> > > > >  3 files changed, 197 insertions(+)
> > > > >  create mode 100644 stable/viewporter/README
> > > > >  create mode 100644 stable/viewporter/viewporter.xml      
> > > > 
> > > > For landing these 5 wayland-protocol patches, either as stable or
> > > > unstable, as Jonas decides:
> > > > 
> > > >   Acked-by: Bryce Harrington <bryce at osg.samsung.com>    
> > 
> > Recorded.  
> 
> Hi,
> 
> the wayland-protocols patches are now pushed:
>    cc276df..83bdaa5  master -> master
> 
> Now we just need a wayland-protocols release. We should have a couple
> of days for the last minute "oops" just in case.
> 
> 
> > > >      
> > > > > Weston:
> > > > > 
> > > > > Pekka Paalanen (12):
> > > > >   compositor: constify weston_surface_build_buffer_matrix()
> > > > >   compositor: refactor into convert_size_by_transform_scale()
> > > > >   compositor: migrate to stable viewporter.xml
> > > > >   compositor: rename scaler to viewport(er)
> > > > >   clients/scaler: migrate to wp_viewporter
> > > > >   clients/simple-damage: migrate to wp_viewporter
> > > > >   protocol: remove scaler.xml
> > > > >   compositor: fix wp_viewport use after free
> > > > >   compositor: check viewport source rect validity
> > > > >   compositor: check viewport dst size validity
> > > > >   compositor: fix wp_viewport.set_source errors
> > > > >   tests: add wp_viewporter tests      
> > > 
> > > The first two patches in this set don't depend on the protocol and look
> > > fine to land during beta.  The rest I'm not sure about, they're a bit
> > > more than a mere rename of the protocol and add functionality.  I don't
> > > have anything against them but wouldn't want to land them on my R-b
> > > alone, and unless they're particularly urgent it would be much more
> > > comfortable to land them post-release.  I reviewed all the patches and
> > > aside from the nitpicks already mentioned, for purposes of landing post
> > > release you can consider them:
> > > 
> > > Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>    
> > 
> > Recorded.
> > 
> > Yes, they missed 1.11 now, will be for 1.12, expect the first two I
> > already pushed with your reviews.  
> 
> This still holds, weston patches won't land until 1.11 is out.

Hi all,

patches 8 - 17 are still in the queue. They apply to master today as
is, the only thing I think that needs fixing is to update the
wayland-protocols dependency, IIRC.

If I understood right, they already have:
Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>
Reviewed-by: Yong Bakos <ybakos at humanoriented.com>

Hmm, Yong, did you give R-b for pathes 8-17? I'm not quite sure if "v3
is Reviewed-by" means that.

Anyone else want to ack/nack?

If no-one replies, I'll push these patches on, say, Thursday with both
Yong and Bryce R-b.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160607/694aa9a4/attachment.sig>