[PATCH wayland-protocols v3 4/7] xdg-shell: Improve error enum formatting some

Benoit Gschwind gschwind at gnu-log.net
Wed Jun 8 15:02:22 UTC 2016


Hello Jonas,

This one do what it tell.

Reviewed-by: Benoit Gschwind <gschwind at gnu-log.net>

Best regards.

On 26/05/2016 06:32, Jonas Ådahl wrote:
> The long lines stood out, break them by putting the summary on its own
> line.
> 
> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> Reviewed-by: Yong Bakos <ybakos at humanoriented.com>
> Reviewed-by: Mike Blumenkrantz <zmike at osg.samsung.com>
> ---
>  unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> index 3116dd4..4a19c83 100644
> --- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> +++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> @@ -37,10 +37,14 @@
>  
>      <enum name="error">
>        <entry name="role" value="0" summary="given wl_surface has another role"/>
> -      <entry name="defunct_surfaces" value="1" summary="xdg_shell was destroyed before children"/>
> -      <entry name="not_the_topmost_popup" value="2" summary="the client tried to map or destroy a non-topmost popup"/>
> -      <entry name="invalid_popup_parent" value="3" summary="the client specified an invalid popup parent surface"/>
> -      <entry name="invalid_surface_state" value="4" summary="the client provided an invalid surface state"/>
> +      <entry name="defunct_surfaces" value="1"
> +	     summary="xdg_shell was destroyed before children"/>
> +      <entry name="not_the_topmost_popup" value="2"
> +	     summary="the client tried to map or destroy a non-topmost popup"/>
> +      <entry name="invalid_popup_parent" value="3"
> +	     summary="the client specified an invalid popup parent surface"/>
> +      <entry name="invalid_surface_state" value="4"
> +	     summary="the client provided an invalid surface state"/>
>      </enum>
>  
>      <request name="destroy" type="destructor">
> 


More information about the wayland-devel mailing list