[PATCH weston 1/2] Move weston source to compositor/

[Pekka Paalanen]

On Mon, 6 Jun 2016 16:01:03 +0300
Giulio Camuffo <giuliocamuffo at gmail.com> wrote:

> 2016-06-06 15:52 GMT+03:00 Pekka Paalanen <ppaalanen at gmail.com>:
> > On Sun, 5 Jun 2016 21:50:33 +0300
> > Giulio Camuffo <giuliocamuffo at gmail.com> wrote:
> >  
> >> 2016-06-03 17:33 GMT+03:00 Pekka Paalanen <ppaalanen at gmail.com>:  
> >> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> >> >
> >> > This is the start of separating weston-the-compositor source files from
> >> > libweston source files.
> >> >
> >> > This is moving all the files related to the 'weston' binary. Also the
> >> > CMS and systemd plugins are moved.
> >> >
> >> > xwayland plugin is not moved, because it will be turned into a
> >> > libweston feature.
> >> >
> >> > To avoid breaking the build, #includes for weston.h are fixed to use
> >> > compositor/weston.h. This serves as a reminder that such files may need
> >> > further attention: moving to the right directory, or maybe using the
> >> > proper -I flags instead.  
> >>
> >> I guess you should move weston-launch too, since it currently cannot
> >> be used by other compositors.  
> >
> > That's true. OTOH, would we like to make it usable for others?
> > Should it be installed with libweston, perhaps under a generic name?  
> 
> I think we should...
> 
> >
> > But can it even be safely made usable for launching arbitrary programs?
> > By design, it would offer the user access to input and DRM devices as
> > root. If it can offer the services to any program, a malicious program
> > can use it to start listening on input devices.  
> 
> but indeed this is the question, and i don't know. I will try to think
> of a way but until then i think it makes sense to keep it with weston.
> On the other hand maybe it's just unnecessary noise if we want to move
> it back later...

Right. IMHO, let's not move it yet but add a note in the README about it.

> >
> > Yes, I suppose I should move it. However, launcher-util has code
> > specific to weston-launch. I could move weston-launch.c but not
> > weston-launch.h.
> >
> > Other opinions on moving weston-launch.c to compositor/?
> >
> > Should I also move screen-share.c to compositor/?

I'll also move screen-share.c to compositor/.

Will re-post the move.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160609/87e51833/attachment.sig>