[PATCH weston v2 2/3] ivi-shell: introduce ivi_layout_view

[Pekka Paalanen]

On Tue, 14 Jun 2016 14:43:40 +0000
"Ucan, Emre (ADITG/SW1)" <eucan at de.adit-jv.com> wrote:

> This patch introduces ivi_layout_view data struct,
> which is a wrapper of weston_view.
> 
> There is always only one ivi_layout_view for an
> ivi_layout_surface and ivi_layout_layer pair.
> A surface could have many views with different
> geometry and transformations, so that a surface
> can be shown on:
> 	1. On many screens
> 	2. On the same screen with different positions
> 
> The geometry of a view is modified, when properties of
> its layer are changed through ivi_layout_interface.
> Users of ivi_layout_interface does not have direct access
> to ivi_layout_view structure.
> 
> v2 changes:
> 	1. Use ivi_view_is_rendered function instead of
> 	   active member
> 	2. Add descriptions to introduced members of
> 	   structs
> 
> Signed-off-by: Emre Ucan <eucan at de.adit-jv.com>
> Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> ---
>  ivi-shell/ivi-layout-private.h |   22 +++-
>  ivi-shell/ivi-layout.c         |  285 ++++++++++++++++++++++++----------------
>  2 files changed, 190 insertions(+), 117 deletions(-)

Hi,

all my major comments have been addressed, so upgraded to R-b, and
pushed this and 3/3... or so I would have, but when I test this, Weston
starts with the launcher overlay active. I have to click a launcher to
make it go to the normal screen. If I click the launcher overlay button
in the middle-bottom instead, I get a second copy of the launcher
overlay, and I can see the first launcher overlay behind it.

Can you reproduce? Could you fix that?


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160615/e21478b1/attachment.sig>