[PATCH weston] compositor-fbdev: drop EGL support

[Quentin Glidic]

On 13/06/2016 13:24, Pekka Paalanen wrote:
> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
>
> EGL code was added to the fbdev backend in
> 4aa756dc7a8d3cf3b4c6f018c3e2a053fff424b0 in 2013, apparently for running
> Weston on libhybris with Android hardware drivers.
>
> This actually had nothing to do with the fbdev backend, really. Fbdev
> was just a convenient platform to plug in the EGL init code and load
> GL-renderer. Fbdev itself was not used at all in this case.
>
> Fbdev should be forgotten and die, as we have better interfaces for
> accelerated rendering and for controlling displays. It may be a bit too
> harsh to remove the whole fbdev backend just yet, but let us at least
> simplify it this much.
>
> Fbdev+EGL has been the unholy union used by proprietary driver stacks of
> hardware vendors in the non-PC world as a quick and dirty way to get
> something out on the screen. In these cases it is actually the EGL
> implementation that does everything internally, fbdev is not needed.
> Fbdev was never meant for the sort anyway.
>
> If anyone still needs this use case, I recommend sticking with a
> outdated Weston to match your outdated platform. Or if you really
> insist, write a new backend that does not pretend to use fbdev and just
> initializes EGL and GL-renderer.
>
> Cc: Adrian Negreanu <groleo at gmail.com>
> Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> ---
>  src/compositor-fbdev.c | 97 ++++++++------------------------------------------
>  src/compositor-fbdev.h |  1 -
>  src/main.c             |  4 +--
>  3 files changed, 16 insertions(+), 86 deletions(-)
>
> [snip]
> diff --git a/src/main.c b/src/main.c
> index 193a845..f835690 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -515,8 +515,7 @@ usage(int error_code)
>  	fprintf(stderr,
>  		"Options for fbdev-backend.so:\n\n"
>  		"  --tty=TTY\t\tThe tty to use\n"
> -		"  --device=DEVICE\tThe framebuffer device to use\n"
> -		"  --use-gl\t\tUse the GL renderer\n\n");
> +		"  --device=DEVICE\tThe framebuffer device to use\n");

You are removing one \n here. We should put the closing on its own line:
		"\n");
This way it won’t change when adding/removing options.


>  #endif
>
>  #if defined(BUILD_HEADLESS_COMPOSITOR)
> @@ -1111,7 +1110,6 @@ load_fbdev_backend(struct weston_compositor *c,
>  	const struct weston_option fbdev_options[] = {
>  		{ WESTON_OPTION_INTEGER, "tty", 0, &config.tty },
>  		{ WESTON_OPTION_STRING, "device", 0, &config.device },
> -		{ WESTON_OPTION_BOOLEAN, "use-gl", 0, &config.use_gl },
>  	};
>
>  	parse_options(fbdev_options, ARRAY_LENGTH(fbdev_options), argc, argv);
>

With that fixed:
Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>

-- 

Quentin “Sardem FF7” Glidic