[PATCH weston] weston-simple-im: Make capitalization consistent in error messages

Bryce Harrington bryce at osg.samsung.com
Thu Jun 16 18:11:24 UTC 2016


On Thu, Jun 16, 2016 at 11:14:01AM -0500, Derek Foreman wrote:
> On 15/06/16 07:59 PM, Bryce Harrington wrote:
> > Signed-off-by: Bryce Harrington <bryce at osg.samsung.com>
> 
> Super important work, proudly
> Reviewed-by: Derek Foreman <derekf at osg.samsung.com>
> 
> Though maybe we should put . on the end if they're capitalized, make
> them complete sentences?

Maybe, yeah, but I'll leave that to someone else.  Looks like there's a
lot more formatting/wording inconsistencies in the client error messages.

Thanks for the reviews, I've pushed the three weston ones.

   b01c31b..f013ce9  master -> master

Bryce

> > ---
> >  clients/weston-simple-im.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/clients/weston-simple-im.c b/clients/weston-simple-im.c
> > index 4c1d7cf..0ee505a 100644
> > --- a/clients/weston-simple-im.c
> > +++ b/clients/weston-simple-im.c
> > @@ -197,13 +197,13 @@ input_method_keyboard_keymap(void *data,
> >  	close(fd);
> >  
> >  	if (!keyboard->keymap) {
> > -		fprintf(stderr, "failed to compile keymap\n");
> > +		fprintf(stderr, "Failed to compile keymap\n");
> >  		return;
> >  	}
> >  
> >  	keyboard->state = xkb_state_new(keyboard->keymap);
> >  	if (!keyboard->state) {
> > -		fprintf(stderr, "failed to create XKB state\n");
> > +		fprintf(stderr, "Failed to create XKB state\n");
> >  		xkb_keymap_unref(keyboard->keymap);
> >  		return;
> >  	}
> > @@ -489,7 +489,7 @@ main(int argc, char *argv[])
> >  
> >  	simple_im.display = wl_display_connect(NULL);
> >  	if (simple_im.display == NULL) {
> > -		fprintf(stderr, "failed to connect to server: %m\n");
> > +		fprintf(stderr, "Failed to connect to server: %m\n");
> >  		return -1;
> >  	}
> >  
> > 


More information about the wayland-devel mailing list