[PATCH wayland-protocols] input-method: Grammar fixups

Yong Bakos junk at humanoriented.com
Fri Jun 17 03:16:26 UTC 2016


Hi Bryce,

> On Jun 15, 2016, at 6:28 PM, Bryce Harrington <bryce at osg.samsung.com> wrote:
> 
> From: Bryce Harrington <bryce at bryceharrington.org>
> 
> Signed-off-by: Bryce Harrington <bryce at bryceharrington.org>
> ---
> unstable/input-method/input-method-unstable-v1.xml | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/unstable/input-method/input-method-unstable-v1.xml b/unstable/input-method/input-method-unstable-v1.xml
> index 274eac8..d30bc72 100644
> --- a/unstable/input-method/input-method-unstable-v1.xml
> +++ b/unstable/input-method/input-method-unstable-v1.xml
> @@ -27,8 +27,8 @@
>   <interface name="zwp_input_method_context_v1" version="1">
>     <description summary="input method context">
>       Corresponds to a text input on the input method side. An input method context
> -      is created on text input activation on the input method side. It allows to
> -      receive information about the text input from the application via events.
> +      is created on text input activation on the input method side. It allows
> +      receiving information about the text input from the application via events.
>       Input method contexts do not keep state after deactivation and should be
>       destroyed after deactivation is handled.
> 
> @@ -39,7 +39,7 @@
>       commit_state request and are used by the input method to indicate
>       the known text input state in events like preedit_string, commit_string,
>       and keysym. The text input can then ignore events from the input method
> -      which are based on an outdated state (for example after a reset).
> +      that are based on an outdated state (for example after a reset).
> 
>       Warning! The protocol described in this file is experimental and
>       backward incompatible changes may be made. Backward compatible changes
> @@ -57,8 +57,8 @@
>       <description summary="commit string">
> 	Send the commit string text for insertion to the application.
> 
> -	The text to commit could be either just a single character after a key
> -	press or the result of some composing (pre-edit). It could be also an
> +	The text to commit could be just a single character after a key
> +	press or the result of some composing (pre-edit). It could also be
> 	empty text when some text should be removed (see
> 	delete_surrounding_text) or when the input cursor should be moved (see
> 	cursor_position).
> @@ -103,7 +103,7 @@
> 	Sets the cursor position inside the composing text (as byte offset)
> 	relative to the start of the composing text.
> 
> -	When index is negative no cursor should be displayed.
> +	When the index is negative no cursor should be displayed.
> 
> 	This request should be sent before sending a preedit_string request.
>       </description>
> @@ -212,7 +212,7 @@
> 	position in bytes within the surrounding text relative to the beginning
> 	of the text. Anchor is the position in bytes of the selection anchor
> 	within the surrounding text relative to the beginning of the text. If
> -	there is no selected text anchor is the same as cursor.
> +	there is no selected text, the anchor is the same as the cursor.

I considered this in ae55234c. But here the author is referring to the args
by name, so, to me, the original sentence makes sense, eg:

If there is no selected text, 'anchor' is the same as 'cursor'.

Anyway, this is:

Reviewed-by: Yong Bakos<ybakos at humanoriented.com>

yong


>       </description>
>       <arg name="text" type="string"/>
>       <arg name="cursor" type="uint"/>
> -- 
> 1.9.1
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel



More information about the wayland-devel mailing list