[PATCH weston] compositor-fbdev: drop EGL support
ppaalanen at gmail.com
Fri Jun 17 08:25:44 UTC 2016
On Thu, 16 Jun 2016 10:06:29 -0500
Derek Foreman <derekf at osg.samsung.com> wrote:
> On 13/06/16 06:24 AM, Pekka Paalanen wrote:
> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > EGL code was added to the fbdev backend in
> > 4aa756dc7a8d3cf3b4c6f018c3e2a053fff424b0 in 2013, apparently for running
> > Weston on libhybris with Android hardware drivers.
> > This actually had nothing to do with the fbdev backend, really. Fbdev
> > was just a convenient platform to plug in the EGL init code and load
> > GL-renderer. Fbdev itself was not used at all in this case.
> > Fbdev should be forgotten and die, as we have better interfaces for
> > accelerated rendering and for controlling displays. It may be a bit too
> > harsh to remove the whole fbdev backend just yet, but let us at least
> > simplify it this much.
> > Fbdev+EGL has been the unholy union used by proprietary driver stacks of
> > hardware vendors in the non-PC world as a quick and dirty way to get
> > something out on the screen. In these cases it is actually the EGL
> > implementation that does everything internally, fbdev is not needed.
> > Fbdev was never meant for the sort anyway.
> > If anyone still needs this use case, I recommend sticking with a
> > outdated Weston to match your outdated platform. Or if you really
> > insist, write a new backend that does not pretend to use fbdev and just
> > initializes EGL and GL-renderer.
> > Cc: Adrian Negreanu <groleo at gmail.com>
> > Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> This looks good to me (modulo Quentin's suggestion, which I missed)
> Reviewed-by: Derek Foreman <derekf at osg.samsung.com>
> ... You have tested it, right? ;)
I quickly tested it runs on inteldrmfb, yeah.
I fixed the issue pointed out by Quentin and pushed:
f013ce9..e77f8ad master -> master
> > ---
> > src/compositor-fbdev.c | 97 ++++++++------------------------------------------
> > src/compositor-fbdev.h | 1 -
> > src/main.c | 4 +--
> > 3 files changed, 16 insertions(+), 86 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 811 bytes
Desc: OpenPGP digital signature
More information about the wayland-devel