[PATCH weston 01/11] tests: introduce struct buffer for client-helper

[Daniel Stone]

Hi,

On 17 June 2016 at 00:13, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> Create a new struct buffer to encapsulate the image representation, the
> wl_buffer, and enough information to tear it all down (munmap) so we
> don't have to leak everything. Some tests might start doing things in
> loops, and leaking would accumulate.
>
> Instead of inventing our own image representation, use pixman_image_t.
> It is a well-tested library worth using, and we already rely on it in
> other places.

Smashing these two changes together does make this patch rather hard
to review. :(

It's not a blocker for me, since I did manage to convince myself it's
fairly correct, but the entanglement is really unfortunate.

The screenshot buffer is still leaked, but that was the case originally, so ...

Cheers,
Daniel