[PATCH weston v2 0/2] Separate Weston from libweston

Pekka Paalanen pekka.paalanen at collabora.co.uk
Thu Jun 23 13:49:35 UTC 2016

On Wed, 22 Jun 2016 21:33:30 -0700
Bryce Harrington <bryce at osg.samsung.com> wrote:

> On Wed, Jun 22, 2016 at 02:44:23PM +0300, Pekka Paalanen wrote:
> > On Thu,  9 Jun 2016 15:20:35 +0300
> > Pekka Paalanen <ppaalanen at gmail.com> wrote:
> >   
> > > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > > 
> > > After these two patches, we have weston-the-compositor sources in compositor/,
> > > and libweston sources in libweston/.
> > > 
> > > Since these patches have been generated with git format-patch -M and so
> > > probably cannot be applied from email, I made the branch available at:
> > > https://git.collabora.com/cgit/user/pq/weston.git/log/?h=migrate2
> > > 
> > > v2: move screen-share.c and note weston-launch.
> > >   
> > 
> > Hi,
> > 
> > so far only Yong has given a Reviewed-by. Bryce gave a sort-of ok but
> > not an official tag, can I take that as an Acked-by?  
> I would like to see the Weston patches that have been waiting for review
> since before the release dealt with first, but given your plan to look
> at and update them yourself you can count that as a provisional Acked-by.

Hi Bryce,

I get the feeling you might be trying to hook me up for more than I
intended. Please, allow me to clarify.

I can handle the rebasing of all patches that add new files that need
to be moved to match the new directory structure. Please, point me to
such patches if I don't otherwise pick them up. I can rebase them, but
that does not imply a Reviewed-by or even Acked-by from me.

I do not promise to handle *all* patches that were sent before the
release. I will also not go and rebase *all* patches and resend them

I expect everyone who is merging patches to master to do the rebase,
because it is really really simple if the only conflicts are due to the
directory reorganization. If you do not know how to easily do it, I
will write a few commands for you to make it simple, if you ask for it.

Once the directory renaming patches are merged to master, I expect
people to send patches in the new directory structure soon afterwards.
I would consider the landing date as the cut-off, rather than the last
release. There is no need to ask anyone to rebase their patches only
because they were written before the directory reorganization.

Because I don't think we completely agree, and I hear your objection, I
won't take your Acked-by. But, respectfully, it seems there is enough
concensus to land this thing. I believe you too agreed that the
reorganization is needed, even though we disagree on how to land it.

> The ones left in the queue are ones I felt like you'd want to have a say
> on, so even apart from the directory split they should be on your
> priority list regardless.  Else I'd have landed them myself.

Yeah, there are a lot of such things. If I end up reviewing them, I can
totally handle the landing too.

If you are still unsure if something is landable or not even after it
has good reviews, do ask me. It is quite possible I haven't considered
the patches to be in my area, and I have a lot take care of anyway so I
need to prioritize. So far one obvious priority for me has been


> > Reviews, Acks, anyone, please?
> > Or do we not want this?
> > 
> > Or should I just go and land this with Yong's R-b and Bryce's A-b, does
> > anyone care?
> > 
> > 
> > Thanks,
> > pq
> > 
> >   
> > > Pekka Paalanen (2):
> > >   Move weston source to compositor/
> > >   Rename src/ to libweston/

More information about the wayland-devel mailing list