[PATCH v3] compositor-x11: fix title overflow in x11_backend_create_output

Daniel Stone daniel at fooishbar.org
Thu Jun 23 21:09:26 UTC 2016


On 7 June 2016 at 03:29, Bryce Harrington <bryce at osg.samsung.com> wrote:
> On Sun, Jun 05, 2016 at 07:01:11PM +0200, Benoit Gschwind wrote:
>> sprintf can overflow the fixed length title which is char[32]. This
>> patch change title to dynamically allocated char array using asprintf or
>> strdup. If one of them fail we leave returning NULL to indicate the
>> failure.
>> Signed-of-by: Benoit Gschwind<gschwind at gnu-log.net>
> Yeah I had noticed this myself earlier and wondered if it should be
> dynamically allocated.  This looks like it would be a possible candidate
> for the stable branch if we do a .1.
> Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>

Pushed with reviews, thanks!
   0f1cac5..5c2f20e  upstream -> master


More information about the wayland-devel mailing list