[PATCH weston v2 2/3] ivi-shell: introduce ivi_layout_view

[Pekka Paalanen]

On Thu, 23 Jun 2016 02:06:24 +0000
"Natsume, Wataru (ADITJ/SWG)" <wnatsume at jp.adit-jv.com> wrote:

> Hello Emre-san,
> 
> v2 patch looks fine with me.
> It passed review at my side except here. (So trivial.)
> 
> +};
> +		<--- It looks better to add blanc.
>  struct ivi_layout_surface {
> 
> Reviewed-by: Wataru Natsume <wnatsume at jp.adit-jv.com>
> 
> Best Regards,
> Wataru Natsume
> 
> ---
> Wataru Natsume / 夏目 亘
> Advanced Driver Information Technology
> Software Group (ADITJ/SWG)
> E-mail: wnatsume at jp.adit-jv.com
> Tel: +81-(0)566-61-4551 / Extension 551-43644
> 
> 
> -----Original Message-----
> From: wayland-devel [mailto:wayland-devel-bounces at lists.freedesktop.org] On Behalf Of Ucan, Emre (ADITG/SW1)
> Sent: Tuesday, June 14, 2016 11:44 PM
> To: wayland-devel at lists.freedesktop.org
> Subject: [PATCH weston v2 2/3] ivi-shell: introduce ivi_layout_view
> 
> This patch introduces ivi_layout_view data struct, which is a wrapper of weston_view.
> 
> There is always only one ivi_layout_view for an ivi_layout_surface and ivi_layout_layer pair.
> A surface could have many views with different geometry and transformations, so that a surface can be shown on:
> 	1. On many screens
> 	2. On the same screen with different positions
> 
> The geometry of a view is modified, when properties of its layer are changed through ivi_layout_interface.
> Users of ivi_layout_interface does not have direct access to ivi_layout_view structure.
> 
> v2 changes:
> 	1. Use ivi_view_is_rendered function instead of
> 	   active member
> 	2. Add descriptions to introduced members of
> 	   structs
> 
> Signed-off-by: Emre Ucan <wbaeucan at de.adit-jv.com>
> Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> ---
>  ivi-shell/ivi-layout-private.h |   22 +++-
>  ivi-shell/ivi-layout.c         |  285 ++++++++++++++++++++++++----------------
>  2 files changed, 190 insertions(+), 117 deletions(-)
> 

Hi,

I fixed the whitespace issue Natsume-san pointed out, and pushed:
   28d240f..37d25bb  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160629/a97e0c7e/attachment.sig>