[PATCH weston 00/11] tests: wrap all pixel data with Pixman
ppaalanen at gmail.com
Wed Jun 29 09:59:53 UTC 2016
On Thu, 23 Jun 2016 15:53:17 +0300
Pekka Paalanen <pekka.paalanen at collabora.co.uk> wrote:
> On Thu, 23 Jun 2016 18:18:18 +1000
> Daniel Stone <daniel at fooishbar.org> wrote:
> > Hi,
> > On 17 June 2016 at 00:13, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > > I believe Pixman is the most future-proof approach, so I went with that, and
> > > started doing everything in pixman_image_t's.
> > >
> > > The patch series works in simple steps: first introduce a struct buffer, which
> > > contains a pixman_image_t and a wl_buffer. Then a new buffer allocator
> > > explicitly for a8r8g8b8 format is introduced, and each test is converted to it
> > > in turn. The old allocator function is hidden once there are no more outside
> > > callers to it, and refactored to remove the pixel format and stride
> > > assumptions. Next, the image comparing, loading and saving APIs are converted
> > > to Pixman images. Cairo remains used for PNG files. Screenshooting returns a
> > > buffer rather than a surface. Finally as a completely new feature, a function
> > > to visualize image differences is added.
> > >
> > > An example of the image error visualisation is here:
> > > https://people.collabora.com/~pq/internal-screenshot-error-00.png
> > > The image represents the difference between a reference image and a
> > > screenshot. The red is wrong, the green is right, and the dark is ignored.
> > >
> > > This series is a pre-requisite for a bunch of sub-surface screenshooting tests
> > > I am developing.
> > LGTM, and wow do we ever need it.
> > Reviewed-by: Daniel Stone <daniels at collabora.com>
> Hi Daniel,
> do you want me to take another shot with patches 1 and 6? I could do
> patch 1, but for 6 I don't know what else to do.
> Anyone else want to chime in?
> If not, I'll land this next week.
All 11 rebased and pushed:
37d25bb..a5bb91d master -> master
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 811 bytes
Desc: OpenPGP digital signature
More information about the wayland-devel